qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: huangy81@chinatelecom.cn
Cc: qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>
Subject: Re: [PATCH 1/2] tests/migration: parse the thread-id key of CpuInfoFast
Date: Thu, 1 Jul 2021 10:15:56 +0100	[thread overview]
Message-ID: <YN2HzJfGIr+NGsaL@work-vm> (raw)
In-Reply-To: <584578c0a0dd781cee45f72ddf517f6e6a41c504.1622729934.git.huangy81@chinatelecom.cn>

* huangy81@chinatelecom.cn (huangy81@chinatelecom.cn) wrote:
> From: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>
> 
> thread_id in CpuInfoFast is deprecated, parse thread-id instead
> after execute qmp query-cpus-fast. fix this so that test can
> go smoothly.
> 
> Signed-off-by: Hyman Huang(黄勇) <huangy81@chinatelecom.cn>

Queued (both 1 and 2)
> ---
>  tests/migration/guestperf/engine.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/migration/guestperf/engine.py b/tests/migration/guestperf/engine.py
> index 208e095794..9e16fa92d2 100644
> --- a/tests/migration/guestperf/engine.py
> +++ b/tests/migration/guestperf/engine.py
> @@ -113,7 +113,7 @@ def _migrate(self, hardware, scenario, src, dst, connect_uri):
>          vcpus = src.command("query-cpus-fast")
>          src_threads = []
>          for vcpu in vcpus:
> -            src_threads.append(vcpu["thread_id"])
> +            src_threads.append(vcpu["thread-id"])
>  
>          # XXX how to get dst timings on remote host ?
>  
> -- 
> 2.24.3
> 
> 
-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK



      parent reply	other threads:[~2021-07-01  9:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03 14:19 [PATCH 1/2] tests/migration: parse the thread-id key of CpuInfoFast huangy81
2021-06-03 14:20 ` [PATCH 2/2] tests/migration: fix "downtime_limit" type when "migrate-set-parameters" huangy81
2021-06-16  6:33   ` Hyman Huang
2021-06-21  8:20   ` Daniel P. Berrangé
2021-06-16  6:26 ` [PATCH 1/2] tests/migration: parse the thread-id key of CpuInfoFast Hyman Huang
2021-06-21  6:29   ` Hyman Huang
2021-06-21  8:20 ` Daniel P. Berrangé
2021-07-01  9:15 ` Dr. David Alan Gilbert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YN2HzJfGIr+NGsaL@work-vm \
    --to=dgilbert@redhat.com \
    --cc=huangy81@chinatelecom.cn \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).