From: David Gibson <david@gibson.dropbear.id.au>
To: Greg Kurz <groug@kaod.org>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 0/2] target/ppc: Drop PowerPCCPUClass::interrupts_big_endian()
Date: Thu, 24 Jun 2021 11:25:43 +1000 [thread overview]
Message-ID: <YNPfFyjxrF1PcrNS@yekko> (raw)
In-Reply-To: <20210622140926.677618-1-groug@kaod.org>
[-- Attachment #1: Type: text/plain, Size: 873 bytes --]
On Tue, Jun 22, 2021 at 04:09:24PM +0200, Greg Kurz wrote:
> Class method is overkill and cause code duplication in CPU setup functions.
> Switch to a more lightweight solution with a unique inline helper.
LGTM, applied to ppc-for-6.1, thanks.
>
> Greg Kurz (2):
> target/ppc: Introduce ppc_interrupts_little_endian()
> target/ppc: Drop PowerPCCPUClass::interrupts_big_endian()
>
> target/ppc/cpu-qom.h | 1 -
> target/ppc/cpu.h | 15 +++++++++++++++
> target/ppc/arch_dump.c | 8 +++-----
> target/ppc/cpu_init.c | 17 -----------------
> target/ppc/excp_helper.c | 3 +--
> 5 files changed, 19 insertions(+), 25 deletions(-)
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-06-24 3:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 14:09 [PATCH 0/2] target/ppc: Drop PowerPCCPUClass::interrupts_big_endian() Greg Kurz
2021-06-22 14:09 ` [PATCH 1/2] target/ppc: Introduce ppc_interrupts_little_endian() Greg Kurz
2021-06-22 18:52 ` Fabiano Rosas
2021-06-22 14:09 ` [PATCH 2/2] target/ppc: Drop PowerPCCPUClass::interrupts_big_endian() Greg Kurz
2021-06-22 18:53 ` Fabiano Rosas
2021-06-24 1:25 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNPfFyjxrF1PcrNS@yekko \
--to=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).