From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Alexander Graf <agraf@csgraf.de>, philmd@redhat.com
Cc: Peter Maydell <peter.maydell@linaro.org>,
lukasstraub2@web.de, berrange@redhat.com,
Leonardo Bras <leobras.c@gmail.com>,
Juan Quintela <quintela@redhat.com>,
qemu-stable@nongnu.org, peterx@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH v3 1/1] yank: Unregister function when using TLS migration
Date: Mon, 28 Jun 2021 12:28:37 +0100 [thread overview]
Message-ID: <YNmyZUy4IwcgZKRy@work-vm> (raw)
In-Reply-To: <7cdf3e49-c68b-f5e5-ae1f-8274203a0f11@csgraf.de>
* Alexander Graf (agraf@csgraf.de) wrote:
>
> On 14.06.21 13:57, Dr. David Alan Gilbert wrote:
> > cc'ing in qemu-stable - I think we'd probably want this on 6.0
> > (It's currently merged as 7de2e8565335c13fb3516cddbe2e40e366cce273 ).
> > Although you'll probably also want the missing dependency fix
> > Philippe is working (See:
> > Mathieu- ( 42) [RFC PATCH] migration: Add missing dependency on GNUTLS )
>
>
> Current master does not compile for me anymore (on macOS) due to this
> change. Can we please either disable yank support and revert this patch,
> pick the GNUTLS dependency patch you refer to quickly and work on a real
> fix afterwards or get the proposed fix in the "missing dependency on
> GNUTLS" discussion done quickly?
>
> Having a broken tree is going to make bisection super painful later.
There was Phil's dependency fix;
https://lore.kernel.org/qemu-devel/YMcTpO2SlVSc%2FHCR@redhat.com/t/
but there still seemed to be some argument if this was the right way to
do it.
Dave
>
> Alex
>
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2021-06-28 11:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 5:40 [PATCH v3 1/1] yank: Unregister function when using TLS migration Leonardo Bras
2021-06-01 11:00 ` Lukas Straub
2021-06-01 17:48 ` Leonardo Brás
2021-06-01 14:50 ` Peter Xu
2021-06-01 15:32 ` Lukas Straub
2021-06-01 16:04 ` Peter Xu
2021-06-01 20:49 ` Leonardo Brás
2021-06-08 17:51 ` Dr. David Alan Gilbert
2021-06-14 11:57 ` Dr. David Alan Gilbert
2021-06-27 11:10 ` Alexander Graf
2021-06-28 11:28 ` Dr. David Alan Gilbert [this message]
2021-06-28 13:12 ` Alexander Graf
2021-06-28 16:35 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNmyZUy4IwcgZKRy@work-vm \
--to=dgilbert@redhat.com \
--cc=agraf@csgraf.de \
--cc=berrange@redhat.com \
--cc=leobras.c@gmail.com \
--cc=lukasstraub2@web.de \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).