From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FC92C2B9F4 for ; Mon, 28 Jun 2021 16:41:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A919161992 for ; Mon, 28 Jun 2021 16:41:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A919161992 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55014 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lxuJj-0005SL-RY for qemu-devel@archiver.kernel.org; Mon, 28 Jun 2021 12:41:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56952) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxuEl-0007rZ-Aq for qemu-devel@nongnu.org; Mon, 28 Jun 2021 12:35:55 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:20160) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lxuEh-0001nw-L2 for qemu-devel@nongnu.org; Mon, 28 Jun 2021 12:35:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624898150; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=8AmNfTYLZa+FZ8RdfaJpBiW/i0/lv1Ak+LMtN0LmArE=; b=C1AB4mblA21m2LIkX9wQN4yZe1j5x2FQDhYS+Gzo8CpbfzBsN2l+cldzkUoOoeKHQVYL4F YKsWgxZgCoetcZc6ewjAkEMl88dB/fKmAp8ErCDqi/9uvfI/J2SkSC7Q8Hj/QSTWVY12Sp rSHwJtS94LHgd1zvnYU+ZHFVWvvJxOM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-430-G6QJOd59N5u_cZNUU_qA2A-1; Mon, 28 Jun 2021 12:35:48 -0400 X-MC-Unique: G6QJOd59N5u_cZNUU_qA2A-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A0EBC801B1C; Mon, 28 Jun 2021 16:35:47 +0000 (UTC) Received: from redhat.com (ovpn-112-219.ams2.redhat.com [10.36.112.219]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A23E55D6AD; Mon, 28 Jun 2021 16:35:39 +0000 (UTC) Date: Mon, 28 Jun 2021 17:35:36 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Alexander Graf Subject: Re: [PATCH v3 1/1] yank: Unregister function when using TLS migration Message-ID: References: <20210601054030.1153249-1-leobras.c@gmail.com> <7cdf3e49-c68b-f5e5-ae1f-8274203a0f11@csgraf.de> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.0.7 (2021-05-04) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.375, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Leonardo Bras , qemu-devel@nongnu.org, lukasstraub2@web.de, Juan Quintela , Peter Maydell , "Dr. David Alan Gilbert" , peterx@redhat.com, qemu-stable@nongnu.org, philmd@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Jun 28, 2021 at 03:12:33PM +0200, Alexander Graf wrote: > > On 28.06.21 13:28, Dr. David Alan Gilbert wrote: > > * Alexander Graf (agraf@csgraf.de) wrote: > >> On 14.06.21 13:57, Dr. David Alan Gilbert wrote: > >>> cc'ing in qemu-stable - I think we'd probably want this on 6.0 > >>> (It's currently merged as 7de2e8565335c13fb3516cddbe2e40e366cce273 ). > >>> Although you'll probably also want the missing dependency fix > >>> Philippe is working (See: > >>> Mathieu- ( 42) [RFC PATCH] migration: Add missing dependency on GNUTLS ) > >> > >> Current master does not compile for me anymore (on macOS) due to this > >> change. Can we please either disable yank support and revert this patch, > >> pick the GNUTLS dependency patch you refer to quickly and work on a real > >> fix afterwards or get the proposed fix in the "missing dependency on > >> GNUTLS" discussion done quickly? > >> > >> Having a broken tree is going to make bisection super painful later. > > There was Phil's dependency fix; > > https://lore.kernel.org/qemu-devel/YMcTpO2SlVSc%2FHCR@redhat.com/t/ > > > > but there still seemed to be some argument if this was the right way to > > do it. > > > Perfect is the enemy of good :). Can we please fix the tree first, then > do "the right way"? I agree that not relying on the GNUTLS header in > that file is sensible, but it's been almost 2 weeks since that simple > one-liner, working fix was posted without anyone following up with a > more complete solution. Phillipe has provided a update of the series that eliminates the compile time dependancy on gnutls from other QEMU headers. Once i've tested that I'll ready a pull request. I'm happy if someone wants to merge that quick one-liner in the meantime as a workaround. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|