* [PATCH] migration: failover: emit a warning when the card is not fully unplugged
@ 2021-07-01 13:14 Laurent Vivier
2021-07-01 16:11 ` Philippe Mathieu-Daudé
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Laurent Vivier @ 2021-07-01 13:14 UTC (permalink / raw)
To: qemu-devel; +Cc: Laurent Vivier, Dr. David Alan Gilbert, Juan Quintela
When the migration fails or is canceled we wait the end of the unplug
operation to be able to plug it back. But if the unplug operation
is never finished we stop to wait and QEMU emits a warning to inform
the user.
Based-on: 20210629155007.629086-1-lvivier@redhat.com
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
migration/migration.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/migration/migration.c b/migration/migration.c
index 3b06d43a7f42..e065c62e5189 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -3689,6 +3689,10 @@ static void qemu_savevm_wait_unplug(MigrationState *s, int old_state,
while (timeout-- && qemu_savevm_state_guest_unplug_pending()) {
qemu_sem_timedwait(&s->wait_unplug_sem, 250);
}
+ if (qemu_savevm_state_guest_unplug_pending()) {
+ warn_report("migration: partially unplugged device on "
+ "failure");
+ }
}
migrate_set_state(&s->state, MIGRATION_STATUS_WAIT_UNPLUG, new_state);
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] migration: failover: emit a warning when the card is not fully unplugged
2021-07-01 13:14 [PATCH] migration: failover: emit a warning when the card is not fully unplugged Laurent Vivier
@ 2021-07-01 16:11 ` Philippe Mathieu-Daudé
2021-07-01 17:59 ` Juan Quintela
2021-07-13 10:58 ` Dr. David Alan Gilbert
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-07-01 16:11 UTC (permalink / raw)
To: Laurent Vivier, qemu-devel; +Cc: Dr. David Alan Gilbert, Juan Quintela
On 7/1/21 3:14 PM, Laurent Vivier wrote:
> When the migration fails or is canceled we wait the end of the unplug
> operation to be able to plug it back. But if the unplug operation
> is never finished we stop to wait and QEMU emits a warning to inform
> the user.
>
> Based-on: 20210629155007.629086-1-lvivier@redhat.com
FYI this ^ tag ...
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
... goes here ;)
> migration/migration.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 3b06d43a7f42..e065c62e5189 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -3689,6 +3689,10 @@ static void qemu_savevm_wait_unplug(MigrationState *s, int old_state,
> while (timeout-- && qemu_savevm_state_guest_unplug_pending()) {
> qemu_sem_timedwait(&s->wait_unplug_sem, 250);
> }
> + if (qemu_savevm_state_guest_unplug_pending()) {
> + warn_report("migration: partially unplugged device on "
> + "failure");
> + }
> }
>
> migrate_set_state(&s->state, MIGRATION_STATUS_WAIT_UNPLUG, new_state);
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] migration: failover: emit a warning when the card is not fully unplugged
2021-07-01 13:14 [PATCH] migration: failover: emit a warning when the card is not fully unplugged Laurent Vivier
2021-07-01 16:11 ` Philippe Mathieu-Daudé
@ 2021-07-01 17:59 ` Juan Quintela
2021-07-13 10:58 ` Dr. David Alan Gilbert
2 siblings, 0 replies; 4+ messages in thread
From: Juan Quintela @ 2021-07-01 17:59 UTC (permalink / raw)
To: Laurent Vivier; +Cc: qemu-devel, Dr. David Alan Gilbert
Laurent Vivier <lvivier@redhat.com> wrote:
> When the migration fails or is canceled we wait the end of the unplug
> operation to be able to plug it back. But if the unplug operation
> is never finished we stop to wait and QEMU emits a warning to inform
> the user.
>
> Based-on: 20210629155007.629086-1-lvivier@redhat.com
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] migration: failover: emit a warning when the card is not fully unplugged
2021-07-01 13:14 [PATCH] migration: failover: emit a warning when the card is not fully unplugged Laurent Vivier
2021-07-01 16:11 ` Philippe Mathieu-Daudé
2021-07-01 17:59 ` Juan Quintela
@ 2021-07-13 10:58 ` Dr. David Alan Gilbert
2 siblings, 0 replies; 4+ messages in thread
From: Dr. David Alan Gilbert @ 2021-07-13 10:58 UTC (permalink / raw)
To: Laurent Vivier; +Cc: qemu-devel, Juan Quintela
* Laurent Vivier (lvivier@redhat.com) wrote:
> When the migration fails or is canceled we wait the end of the unplug
> operation to be able to plug it back. But if the unplug operation
> is never finished we stop to wait and QEMU emits a warning to inform
> the user.
>
> Based-on: 20210629155007.629086-1-lvivier@redhat.com
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Queued
> ---
> migration/migration.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 3b06d43a7f42..e065c62e5189 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -3689,6 +3689,10 @@ static void qemu_savevm_wait_unplug(MigrationState *s, int old_state,
> while (timeout-- && qemu_savevm_state_guest_unplug_pending()) {
> qemu_sem_timedwait(&s->wait_unplug_sem, 250);
> }
> + if (qemu_savevm_state_guest_unplug_pending()) {
> + warn_report("migration: partially unplugged device on "
> + "failure");
> + }
> }
>
> migrate_set_state(&s->state, MIGRATION_STATUS_WAIT_UNPLUG, new_state);
> --
> 2.31.1
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-07-13 10:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-01 13:14 [PATCH] migration: failover: emit a warning when the card is not fully unplugged Laurent Vivier
2021-07-01 16:11 ` Philippe Mathieu-Daudé
2021-07-01 17:59 ` Juan Quintela
2021-07-13 10:58 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).