From: David Gibson <david@gibson.dropbear.id.au>
To: Fabiano Rosas <farosas@linux.ibm.com>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, groug@kaod.org
Subject: Re: [PATCH 2/3] target/ppc: Fix compilation with FLUSH_ALL_TLBS debug option
Date: Sat, 3 Jul 2021 17:31:17 +1000 [thread overview]
Message-ID: <YOASRXaiS8LW4gla@yekko> (raw)
In-Reply-To: <20210702215235.1941771-3-farosas@linux.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 2909 bytes --]
On Fri, Jul 02, 2021 at 06:52:34PM -0300, Fabiano Rosas wrote:
> ../target/ppc/mmu_helper.c: In function 'helper_store_ibatu':
> ../target/ppc/mmu_helper.c:1802:17: error: unused variable 'cpu' [-Werror=unused-variable]
> 1802 | PowerPCCPU *cpu = env_archcpu(env);
> | ^~~
> ../target/ppc/mmu_helper.c: In function 'helper_store_dbatu':
> ../target/ppc/mmu_helper.c:1838:17: error: unused variable 'cpu' [-Werror=unused-variable]
> 1838 | PowerPCCPU *cpu = env_archcpu(env);
> | ^~~
> ../target/ppc/mmu_helper.c: In function 'helper_store_601_batu':
> ../target/ppc/mmu_helper.c:1874:17: error: unused variable 'cpu' [-Werror=unused-variable]
> 1874 | PowerPCCPU *cpu = env_archcpu(env);
> | ^~~
> ../target/ppc/mmu_helper.c: In function 'helper_store_601_batl':
> ../target/ppc/mmu_helper.c:1919:17: error: unused variable 'cpu' [-Werror=unused-variable]
> 1919 | PowerPCCPU *cpu = env_archcpu(env);
>
> Fixes: db70b31144 ("target/ppc: Use env_cpu, env_archcpu")
> Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
Applied to ppc-for-6.1, thanks.
> ---
> target/ppc/mmu_helper.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/target/ppc/mmu_helper.c b/target/ppc/mmu_helper.c
> index ff2c6bdd8c..67caba6369 100644
> --- a/target/ppc/mmu_helper.c
> +++ b/target/ppc/mmu_helper.c
> @@ -1798,9 +1798,6 @@ static inline void dump_store_bat(CPUPPCState *env, char ID, int ul, int nr,
> void helper_store_ibatu(CPUPPCState *env, uint32_t nr, target_ulong value)
> {
> target_ulong mask;
> -#if defined(FLUSH_ALL_TLBS)
> - PowerPCCPU *cpu = env_archcpu(env);
> -#endif
>
> dump_store_bat(env, 'I', 0, nr, value);
> if (env->IBAT[0][nr] != value) {
> @@ -1834,9 +1831,6 @@ void helper_store_ibatl(CPUPPCState *env, uint32_t nr, target_ulong value)
> void helper_store_dbatu(CPUPPCState *env, uint32_t nr, target_ulong value)
> {
> target_ulong mask;
> -#if defined(FLUSH_ALL_TLBS)
> - PowerPCCPU *cpu = env_archcpu(env);
> -#endif
>
> dump_store_bat(env, 'D', 0, nr, value);
> if (env->DBAT[0][nr] != value) {
> @@ -1871,7 +1865,6 @@ void helper_store_601_batu(CPUPPCState *env, uint32_t nr, target_ulong value)
> {
> target_ulong mask;
> #if defined(FLUSH_ALL_TLBS)
> - PowerPCCPU *cpu = env_archcpu(env);
> int do_inval;
> #endif
>
> @@ -1916,7 +1909,6 @@ void helper_store_601_batl(CPUPPCState *env, uint32_t nr, target_ulong value)
> #if !defined(FLUSH_ALL_TLBS)
> target_ulong mask;
> #else
> - PowerPCCPU *cpu = env_archcpu(env);
> int do_inval;
> #endif
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-07-03 7:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 21:52 [PATCH 0/3] target/ppc: MMU debug fixes Fabiano Rosas
2021-07-02 21:52 ` [PATCH 1/3] target/ppc: Fix compilation with DUMP_PAGE_TABLES debug option Fabiano Rosas
2021-07-03 7:29 ` David Gibson
2021-07-02 21:52 ` [PATCH 2/3] target/ppc: Fix compilation with FLUSH_ALL_TLBS " Fabiano Rosas
2021-07-03 7:31 ` David Gibson [this message]
2021-07-02 21:52 ` [PATCH 3/3] target/ppc: Fix compilation with DEBUG_BATS " Fabiano Rosas
2021-07-03 7:32 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOASRXaiS8LW4gla@yekko \
--to=david@gibson.dropbear.id.au \
--cc=farosas@linux.ibm.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).