From: David Gibson <david@gibson.dropbear.id.au>
To: Fabiano Rosas <farosas@linux.ibm.com>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, groug@kaod.org
Subject: Re: [PATCH 3/3] target/ppc: Fix compilation with DEBUG_BATS debug option
Date: Sat, 3 Jul 2021 17:32:50 +1000 [thread overview]
Message-ID: <YOASorRJAusWKkam@yekko> (raw)
In-Reply-To: <20210702215235.1941771-4-farosas@linux.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 3426 bytes --]
On Fri, Jul 02, 2021 at 06:52:35PM -0300, Fabiano Rosas wrote:
> ../target/ppc/mmu-hash32.c: In function 'ppc_hash32_bat_lookup':
> ../target/ppc/mmu-hash32.c:204:13: error: 'BATu' undeclared (first use in this function);
> 204 | BATu = &BATut[i];
> | ^~~~
> | BATut
> ../target/ppc/mmu-hash32.c:205:13: error: 'BATl' undeclared (first use in this function);
> 205 | BATl = &BATlt[i];
> | ^~~~
> | BATlt
> ../target/ppc/mmu-hash32.c:206:13: error: 'BEPIu' undeclared (first use in this function)
> 206 | BEPIu = *BATu & BATU32_BEPIU;
> | ^~~~~
> ../target/ppc/mmu-hash32.c:206:29: error: 'BATU32_BEPIU' undeclared (first use in this function);
> 206 | BEPIu = *BATu & BATU32_BEPIU;
> | ^~~~~~~~~~~~
> | BATU32_BEPI
> ../target/ppc/mmu-hash32.c:207:13: error: 'BEPIl' undeclared (first use in this function)
> 207 | BEPIl = *BATu & BATU32_BEPIL;
> | ^~~~~
> ../target/ppc/mmu-hash32.c:207:29: error: 'BATU32_BEPIL' undeclared (first use in this function);
> 207 | BEPIl = *BATu & BATU32_BEPIL;
> | ^~~~~~~~~~~~
> | BATU32_BEPI
> ../target/ppc/mmu-hash32.c:208:13: error: 'bl' undeclared (first use in this function)
> 208 | bl = (*BATu & 0x00001FFC) << 15;
> | ^~
>
> Fixes: 9813279664 ("target-ppc: Disentangle BAT code for 32-bit hash MMUs")
> Signed-off-by: Fabiano Rosas <farosas@linux.ibm.com>
Applied to ppc-for-6.1, thanks.
> ---
> target/ppc/mmu-hash32.c | 5 ++++-
> target/ppc/mmu-hash32.h | 2 ++
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/target/ppc/mmu-hash32.c b/target/ppc/mmu-hash32.c
> index 9f0a497657..330bb0432e 100644
> --- a/target/ppc/mmu-hash32.c
> +++ b/target/ppc/mmu-hash32.c
> @@ -27,7 +27,7 @@
> #include "mmu-hash32.h"
> #include "exec/log.h"
>
> -/* #define DEBUG_BAT */
> +/* #define DEBUG_BATS */
>
> #ifdef DEBUG_BATS
> # define LOG_BATS(...) qemu_log_mask(CPU_LOG_MMU, __VA_ARGS__)
> @@ -199,6 +199,9 @@ static hwaddr ppc_hash32_bat_lookup(PowerPCCPU *cpu, target_ulong ea,
> /* No hit */
> #if defined(DEBUG_BATS)
> if (qemu_log_enabled()) {
> + target_ulong *BATu, *BATl;
> + target_ulong BEPIl, BEPIu, bl;
> +
> LOG_BATS("no BAT match for " TARGET_FMT_lx ":\n", ea);
> for (i = 0; i < 4; i++) {
> BATu = &BATut[i];
> diff --git a/target/ppc/mmu-hash32.h b/target/ppc/mmu-hash32.h
> index 898021f0d8..4fdeaf1937 100644
> --- a/target/ppc/mmu-hash32.h
> +++ b/target/ppc/mmu-hash32.h
> @@ -22,6 +22,8 @@ int ppc_hash32_handle_mmu_fault(PowerPCCPU *cpu, vaddr address, int rw,
> * Block Address Translation (BAT) definitions
> */
>
> +#define BATU32_BEPIU 0xf0000000
> +#define BATU32_BEPIL 0x0ffe0000
> #define BATU32_BEPI 0xfffe0000
> #define BATU32_BL 0x00001ffc
> #define BATU32_VS 0x00000002
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-07-03 7:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 21:52 [PATCH 0/3] target/ppc: MMU debug fixes Fabiano Rosas
2021-07-02 21:52 ` [PATCH 1/3] target/ppc: Fix compilation with DUMP_PAGE_TABLES debug option Fabiano Rosas
2021-07-03 7:29 ` David Gibson
2021-07-02 21:52 ` [PATCH 2/3] target/ppc: Fix compilation with FLUSH_ALL_TLBS " Fabiano Rosas
2021-07-03 7:31 ` David Gibson
2021-07-02 21:52 ` [PATCH 3/3] target/ppc: Fix compilation with DEBUG_BATS " Fabiano Rosas
2021-07-03 7:32 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOASorRJAusWKkam@yekko \
--to=david@gibson.dropbear.id.au \
--cc=farosas@linux.ibm.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).