From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2497C07E95 for ; Wed, 7 Jul 2021 11:05:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D1E061C90 for ; Wed, 7 Jul 2021 11:05:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D1E061C90 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52394 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m15NH-00051N-LK for qemu-devel@archiver.kernel.org; Wed, 07 Jul 2021 07:05:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m15M4-0003CH-GP for qemu-devel@nongnu.org; Wed, 07 Jul 2021 07:04:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:41717) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m15M2-0003aA-OC for qemu-devel@nongnu.org; Wed, 07 Jul 2021 07:04:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625655873; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ybIdDlfMuZqTFsDh1dZHPOSaejuYX/IaRKfb2s+rvxE=; b=UftGXY6WzRV5QJveYGd3G7UFU6kw0A+bnFSfSgTdcKXj9qkfYpb+wOwLn7uBM2nFRbPeHD 3pPmVIcj/mVcYOCAU0XuJdjq+akJczhPKbXDZckXCRL4oTvUtNCQN2gFegETH6flAd3MlY OFnlLUjaRGVxoj43/9YK4NNxfrxHKqI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-588-SKcb_vQbM1S6sft6qY067A-1; Wed, 07 Jul 2021 07:04:28 -0400 X-MC-Unique: SKcb_vQbM1S6sft6qY067A-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C6A4E362F8; Wed, 7 Jul 2021 11:04:27 +0000 (UTC) Received: from redhat.com (ovpn-113-81.ams2.redhat.com [10.36.113.81]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AE96D60843; Wed, 7 Jul 2021 11:04:26 +0000 (UTC) Date: Wed, 7 Jul 2021 12:04:23 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Paolo Bonzini Subject: Re: [PATCH] osdep: fix HAVE_BROKEN_SIZE_MAX case Message-ID: References: <20210707105600.342309-1-pbonzini@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210707105600.342309-1-pbonzini@redhat.com> User-Agent: Mutt/2.0.7 (2021-05-04) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.439, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Frederic Bezies , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Jul 07, 2021 at 12:56:00PM +0200, Paolo Bonzini wrote: > While config-host.mak entries are expanded to "1" for compatibility with > create-config.sh, tests done directly in meson.build expand to the empty > string and cannot be placed to the right of the && operator. Adjust > osdep.h after commit e46bd55d9c ("configure: convert HAVE_BROKEN_SIZE_MAX > to meson", 2021-07-06) changed the way HAVE_BROKEN_SIZE_MAX is defined. > > Reported-by: Frederic Bezies > Fixes: e46bd55d9c ("configure: convert HAVE_BROKEN_SIZE_MAX to meson", 2021-07-06) > Resolves: #463 FWIW, although gitlab allows these short references, it is generally not desirable to use it. When browsing commits in a fork, the hyperlink for '#463' will attempt to be resolved against the fork's issue tracker, not the main repo. It won't exist in the fork and thus won't get linked. Thus it preferrable to include at least the project path too: Resolves: qemu-project/qemu#463 or simply the URL to the issue: Resolves: https://gitlab.com/qemu-project/qemu/-/issues/463 Personally I like the latter, since you can then click the issue URL when browsing commits in your shell terminal. > Signed-off-by: Paolo Bonzini > --- > include/qemu/osdep.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé > > diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h > index c91a78b5e6..60718fc342 100644 > --- a/include/qemu/osdep.h > +++ b/include/qemu/osdep.h > @@ -256,7 +256,7 @@ extern "C" { > /* Mac OSX has a bug that incorrectly defines SIZE_MAX with > * the wrong type. Our replacement isn't usable in preprocessor > * expressions, but it is sufficient for our needs. */ > -#if defined(HAVE_BROKEN_SIZE_MAX) && HAVE_BROKEN_SIZE_MAX > +#ifdef HAVE_BROKEN_SIZE_MAX > #undef SIZE_MAX > #define SIZE_MAX ((size_t)-1) > #endif > -- > 2.31.1 > Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|