Re: [PATCH] docs: Add '-device intel-iommu' entry

[Peter Xu <peterx@redhat.com>]

On Wed, Jul 07, 2021 at 11:35:43AM +0800, Jason Wang wrote:
> 
> 在 2021/6/12 上午2:55, Peter Xu 写道:
> > The parameters of intel-iommu device are non-trivial to understand.  Add an
> > entry for it so that people can reference to it when using.
> > 
> > There're actually a few more options there, but I hide them explicitly because
> > they shouldn't be used by normal QEMU users.
> > 
> > Cc: Chao Yang <chayang@redhat.com>
> > Cc: Lei Yang <leiyang@redhat.com>
> > Cc: Jing Zhao <jinzhao@redhat.com>
> > Cc: Jason Wang <jasowang@redhat.com>
> > Cc: Michael S. Tsirkin <mst@redhat.com>
> > Cc: Alex Williamson <alex.williamson@redhat.com>
> > Signed-off-by: Peter Xu <peterx@redhat.com>
> > ---
> >   qemu-options.hx | 32 ++++++++++++++++++++++++++++++++
> >   1 file changed, 32 insertions(+)
> > 
> > diff --git a/qemu-options.hx b/qemu-options.hx
> > index 14258784b3a..4bb04243907 100644
> > --- a/qemu-options.hx
> > +++ b/qemu-options.hx
> > @@ -926,6 +926,38 @@ SRST
> >   ``-device pci-ipmi-bt,bmc=id``
> >       Like the KCS interface, but defines a BT interface on the PCI bus.
> > +
> > +``-device intel-iommu[,option=...]``
> > +    This is only supported by ``-machine q35``, which will enable Intel VT-d
> > +    emulation within the guest.  It supports below options:
> > +
> > +    ``intremap=on|off`` (default: auto)
> > +        This enables interrupt remapping feature in the guest.
> 
> 
> I think we don't need "in the guest" here.

Sure.

> 
> Other than this:
> 
> Reviewed-by: Jason Wang <jasowang@redhat.com>

Thanks,

-- 
Peter Xu