From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9543C07E95 for ; Wed, 7 Jul 2021 16:46:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B3496194B for ; Wed, 7 Jul 2021 16:46:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B3496194B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49064 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1AhD-0003e8-My for qemu-devel@archiver.kernel.org; Wed, 07 Jul 2021 12:46:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39182) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1Afw-0001yA-OX for qemu-devel@nongnu.org; Wed, 07 Jul 2021 12:45:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:48945) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1Afv-00065o-CT for qemu-devel@nongnu.org; Wed, 07 Jul 2021 12:45:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625676326; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0Ow/CVQJo1CSvOZKtoc12ZmW2mmTmUVUN47FbF3wA9E=; b=eAMuC/gLQR1joL6nL71R3tvlhBK7XL3NxVh1UXrRRlJP5VgsFVbTW9UbLeo5o6Aiw7V0Cb nQexOvUNPoy0BRPnVE2Q+YtIV5kelhGd+RSVjsEcQoOV+H+GO8ykphM2UcAJtFJZdlGNTs CUa1g/+dIM2oZcJNHmf2xymwoigXtFM= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-502-vu21jVutMaGORTtIHEwdxw-1; Wed, 07 Jul 2021 12:45:25 -0400 X-MC-Unique: vu21jVutMaGORTtIHEwdxw-1 Received: by mail-qv1-f70.google.com with SMTP id k12-20020a0cfd6c0000b029020df9543019so2024282qvs.14 for ; Wed, 07 Jul 2021 09:45:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0Ow/CVQJo1CSvOZKtoc12ZmW2mmTmUVUN47FbF3wA9E=; b=QzoHGUUTu5vZ5AKyC1q+UqhVkemLJPy2Ow/UoXfNnHDFEdUjma830BCGRGQlsA0J6p fU48ti8lSSyDL/iJCcaNe+1xsdlUCd3VTmioFulsgY4wMVrJSirA2s/dkk1q8J61+Z0l oJBJgCN8s95+XrWakQMl4aY2x7THErBiBc0SKZMyWlMaVpYr4S9gVkYsyR4qK+bCoQwD XQXnXLRvmU5UsK2at4Y180mt08wtza+s5PNlZLnoLLImv9rrLctALquyUopb0CKVQrgF ghfTZTv/cyPaHdUytKSjgY9EMPi59i9sGJ5MXZcKZw8iA06oEEyhw7NwvRUCg8SYYnfr JMQA== X-Gm-Message-State: AOAM5324u5BzMzd5Fs9y1cUsnAbPmeyVKOjnTjUZlzTLV4Ww5h0lFQpi yZ+qIEy7nUFODlH8mwdi44c27iF2KlqFtnrNHkLGgxPz6Qdou9XkMKDO77CwBip7w8mkQqeyOG/ qklQjxOQyOakI8do= X-Received: by 2002:a0c:e087:: with SMTP id l7mr24712885qvk.22.1625676324574; Wed, 07 Jul 2021 09:45:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxclvtIRABS0nP5m723CMkQaBaAVSkcGdnfGDH4OiiiVT47rk3zIEpl+knprFZQ5bvRYYBapw== X-Received: by 2002:a0c:e087:: with SMTP id l7mr24712864qvk.22.1625676324402; Wed, 07 Jul 2021 09:45:24 -0700 (PDT) Received: from t490s (bras-base-toroon474qw-grc-65-184-144-111-238.dsl.bell.ca. [184.144.111.238]) by smtp.gmail.com with ESMTPSA id u22sm2796950qkp.85.2021.07.07.09.45.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jul 2021 09:45:23 -0700 (PDT) Date: Wed, 7 Jul 2021 12:45:22 -0400 From: Peter Xu To: "Wang, Wei W" Subject: Re: [PATCH] migration: Move bitmap_mutex out of migration_bitmap_clear_dirty() Message-ID: References: <304fc749-03a0-b58d-05cc-f0d78350e015@redhat.com> <604935aa45114d889800f6ccc23c6b13@intel.com> <824a1d77-eab0-239f-5104-49c49d6ad285@redhat.com> <562b42cbd5674853af21be3297fbaada@intel.com> MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.439, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Hailiang Zhang , Juan Quintela , David Hildenbrand , "qemu-devel@nongnu.org" , "Dr . David Alan Gilbert" , Leonardo Bras Soares Passos Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Jul 07, 2021 at 12:45:32PM +0000, Wang, Wei W wrote: > Btw, what would you think if we change mutex to QemuSpin? It will also reduce the overhead, I think. As I replied at the other place, the bottleneck we encountered is the lock taking not sleeping, so I'm afraid spinlock will have the same issue. Thanks, -- Peter Xu