From: Peter Xu <peterx@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: "Michael S . Tsirkin" <mst@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
qemu-devel@nongnu.org,
"Alexander Duyck" <alexander.duyck@gmail.com>,
qemu-stable@nongnu.org, "Wei Wang" <wei.w.wang@intel.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH v1 2/2] virtio-balloon: disallow postcopy with VIRTIO_BALLOON_F_FREE_PAGE_HINT
Date: Wed, 7 Jul 2021 14:02:53 -0400 [thread overview]
Message-ID: <YOXsTQoq6eeIR8B5@t490s> (raw)
In-Reply-To: <20210707140655.30982-3-david@redhat.com>
On Wed, Jul 07, 2021 at 04:06:55PM +0200, David Hildenbrand wrote:
> As it never worked properly, let's disable it via the postcopy notifier on
> the destination. Trying to set "migrate_set_capability postcopy-ram on"
> on the destination now results in "virtio-balloon: 'free-page-hint' does
> not support postcopy Error: Postcopy is not supported".
Would it be possible to do this in reversed order? Say, dynamically disable
free-page-hinting if postcopy capability is set when migration starts? Perhaps
it can also be re-enabled automatically when migration completes?
I see postcopy a "functional" feature and free-page-hint a "performance"
feature, from that pov IMHO it's better to not block function for performance.
Thanks,
--
Peter Xu
next prev parent reply other threads:[~2021-07-07 18:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 14:06 [PATCH v1 0/2] virtio-balloon: disallow postcopy with VIRTIO_BALLOON_F_FREE_PAGE_HINT David Hildenbrand
2021-07-07 14:06 ` [PATCH v1 1/2] migration/postcopy-ram: define type for "struct PostcopyNotifyData" David Hildenbrand
2021-07-07 20:30 ` Pankaj Gupta
2021-07-07 14:06 ` [PATCH v1 2/2] virtio-balloon: disallow postcopy with VIRTIO_BALLOON_F_FREE_PAGE_HINT David Hildenbrand
2021-07-07 18:02 ` Peter Xu [this message]
2021-07-07 18:57 ` David Hildenbrand
2021-07-07 19:07 ` Michael S. Tsirkin
2021-07-07 20:08 ` Peter Xu
2021-07-07 21:22 ` Alexander Duyck
2021-07-07 22:40 ` Peter Xu
2021-07-08 7:14 ` David Hildenbrand
2021-07-08 7:23 ` David Hildenbrand
2021-07-07 19:05 ` Michael S. Tsirkin
2021-07-07 19:14 ` David Hildenbrand
2021-07-07 19:19 ` Michael S. Tsirkin
2021-07-07 19:47 ` David Hildenbrand
2021-07-07 19:57 ` Michael S. Tsirkin
2021-07-08 8:19 ` David Hildenbrand
2021-07-08 19:07 ` Dr. David Alan Gilbert
2021-07-09 11:27 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOXsTQoq6eeIR8B5@t490s \
--to=peterx@redhat.com \
--cc=alexander.duyck@gmail.com \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=mst@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=quintela@redhat.com \
--cc=wei.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).