From: David Gibson <david@gibson.dropbear.id.au>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
Christian Zigotzky <chzigotzky@xenosoft.de>
Subject: Re: [PATCH] target/ppc: mtmsrd is an illegal instruction on BookE
Date: Thu, 8 Jul 2021 12:44:06 +1000 [thread overview]
Message-ID: <YOZmdsNUrcuIbfV/@yekko> (raw)
In-Reply-To: <20210706051321.609046-1-npiggin@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1050 bytes --]
On Tue, Jul 06, 2021 at 03:13:21PM +1000, Nicholas Piggin wrote:
> MSR is a 32-bit register in BookE and there is no mtmsrd instruction.
>
> Cc: Christian Zigotzky <chzigotzky@xenosoft.de>
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Applied to ppc-for-6.1, thanks.
> ---
> target/ppc/translate.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/target/ppc/translate.c b/target/ppc/translate.c
> index f65d1e81ea..d1f482b0f3 100644
> --- a/target/ppc/translate.c
> +++ b/target/ppc/translate.c
> @@ -4940,6 +4940,11 @@ static void gen_mtcrf(DisasContext *ctx)
> #if defined(TARGET_PPC64)
> static void gen_mtmsrd(DisasContext *ctx)
> {
> + if (unlikely(!is_book3s_arch2x(ctx))) {
> + gen_invalid(ctx);
> + return;
> + }
> +
> CHK_SV;
>
> #if !defined(CONFIG_USER_ONLY)
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-07-08 4:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 5:13 [PATCH] target/ppc: mtmsrd is an illegal instruction on BookE Nicholas Piggin
2021-07-08 2:44 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOZmdsNUrcuIbfV/@yekko \
--to=david@gibson.dropbear.id.au \
--cc=chzigotzky@xenosoft.de \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).