From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: "reviewer:Incompatible changes" <libvir-list@redhat.com>,
qemu-devel@nongnu.org,
"open list:Block layer core" <qemu-block@nongnu.org>,
Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH 2/2] qemu-img: Require -F with -b backing image
Date: Thu, 8 Jul 2021 15:00:36 +0200 [thread overview]
Message-ID: <YOb29Jy1rjyfyf25@redhat.com> (raw)
In-Reply-To: <20210503213600.569128-3-eblake@redhat.com>
Am 03.05.2021 um 23:36 hat Eric Blake geschrieben:
> @@ -17,7 +14,7 @@ qemu-io: can't open device TEST_DIR/t.qcow2: Could not open backing file: Unknow
> no file open, try 'help open'
> read 4096/4096 bytes at offset 0
> 4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> -qemu-img: warning: Deprecated use of backing file without explicit backing format, use of this image requires potentially unsafe format probing
> +qemu-img: Could not change the backing file to '/home/eblake/qemu/build/tests/qemu-iotests/scratch/t.qcow2.base': Invalid argument
> read 4096/4096 bytes at offset 0
> 4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
This is not exactly an improvement for the error message. Maybe worth a
follow-up patch?
Kevin
next prev parent reply other threads:[~2021-07-08 13:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 21:35 [PATCH 0/2] Remove deprecated qemu-img backing file without format Eric Blake
2021-05-03 21:35 ` [PATCH 1/2] qcow2: Prohibit backing file changes in 'qemu-img amend' Eric Blake
2021-05-03 21:36 ` [PATCH 2/2] qemu-img: Require -F with -b backing image Eric Blake
2021-05-03 21:45 ` Eric Blake
2021-05-04 13:21 ` Eric Blake
2021-07-08 13:00 ` Kevin Wolf [this message]
2021-07-08 14:03 ` Eric Blake
2021-07-07 21:17 ` [PATCH 0/2] Remove deprecated qemu-img backing file without format Eric Blake
2021-07-08 13:03 ` Kevin Wolf
2021-07-07 21:36 ` Connor Kuehl
2021-07-08 15:52 ` [PATCH 3/2] qemu-img: Improve error for rebase without backing format Eric Blake
2021-07-08 16:58 ` Kevin Wolf
2021-07-09 13:21 ` Eric Blake
2021-07-09 11:12 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOb29Jy1rjyfyf25@redhat.com \
--to=kwolf@redhat.com \
--cc=eblake@redhat.com \
--cc=libvir-list@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).