* [PATCH] block/rbd: fix type of task->complete
@ 2021-07-07 18:04 Peter Lieven
2021-07-07 18:04 ` [PATCH] MAINTAINERS: update block/rbd.c maintainer Peter Lieven
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Peter Lieven @ 2021-07-07 18:04 UTC (permalink / raw)
To: qemu-block
Cc: kwolf, idryomov, berrange, Peter Lieven, qemu-devel, ct, pbonzini,
idryomov, mreitz, dillaman
task->complete is a bool not an integer.
Signed-off-by: Peter Lieven <pl@kamp.de>
---
block/rbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/rbd.c b/block/rbd.c
index 01a7b94d62..dcf82b15b8 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -1066,7 +1066,7 @@ static int qemu_rbd_resize(BlockDriverState *bs, uint64_t size)
static void qemu_rbd_finish_bh(void *opaque)
{
RBDTask *task = opaque;
- task->complete = 1;
+ task->complete = true;
aio_co_wake(task->co);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] MAINTAINERS: update block/rbd.c maintainer
2021-07-07 18:04 [PATCH] block/rbd: fix type of task->complete Peter Lieven
@ 2021-07-07 18:04 ` Peter Lieven
2021-07-08 10:44 ` Ilya Dryomov
2021-07-07 21:51 ` [PATCH] block/rbd: fix type of task->complete Connor Kuehl
2021-07-08 10:41 ` Ilya Dryomov
2 siblings, 1 reply; 7+ messages in thread
From: Peter Lieven @ 2021-07-07 18:04 UTC (permalink / raw)
To: qemu-block
Cc: kwolf, idryomov, berrange, Peter Lieven, qemu-devel, ct, pbonzini,
idryomov, mreitz, dillaman
adding myself as a designated reviewer.
Signed-off-by: Peter Lieven <pl@kamp.de>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 516db737d1..cfda57e825 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3058,6 +3058,7 @@ F: block/vmdk.c
RBD
M: Ilya Dryomov <idryomov@gmail.com>
+R: Peter Lieven <pl@kamp.de>
L: qemu-block@nongnu.org
S: Supported
F: block/rbd.c
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] MAINTAINERS: update block/rbd.c maintainer
2021-07-07 18:04 ` [PATCH] MAINTAINERS: update block/rbd.c maintainer Peter Lieven
@ 2021-07-08 10:44 ` Ilya Dryomov
2021-07-08 12:06 ` Kevin Wolf
0 siblings, 1 reply; 7+ messages in thread
From: Ilya Dryomov @ 2021-07-08 10:44 UTC (permalink / raw)
To: Peter Lieven
Cc: Kevin Wolf, Ilya Dryomov, Daniel P. Berrangé, qemu-block, ct,
qemu-devel, Paolo Bonzini, Max Reitz, Jason Dillaman
On Wed, Jul 7, 2021 at 8:05 PM Peter Lieven <pl@kamp.de> wrote:
>
> adding myself as a designated reviewer.
>
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 516db737d1..cfda57e825 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3058,6 +3058,7 @@ F: block/vmdk.c
>
> RBD
> M: Ilya Dryomov <idryomov@gmail.com>
> +R: Peter Lieven <pl@kamp.de>
> L: qemu-block@nongnu.org
> S: Supported
> F: block/rbd.c
> --
> 2.17.1
>
>
Nit: I would change the title to "MAINTAINERS: add block/rbd.c reviewer"
or something like that.
Acked-by: Ilya Dryomov <idryomov@gmail.com>
Thanks again for volunteering!
Ilya
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] MAINTAINERS: update block/rbd.c maintainer
2021-07-08 10:44 ` Ilya Dryomov
@ 2021-07-08 12:06 ` Kevin Wolf
0 siblings, 0 replies; 7+ messages in thread
From: Kevin Wolf @ 2021-07-08 12:06 UTC (permalink / raw)
To: Ilya Dryomov
Cc: Ilya Dryomov, Daniel P. Berrangé, qemu-block, Peter Lieven,
ct, qemu-devel, Paolo Bonzini, Max Reitz, Jason Dillaman
Am 08.07.2021 um 12:44 hat Ilya Dryomov geschrieben:
> On Wed, Jul 7, 2021 at 8:05 PM Peter Lieven <pl@kamp.de> wrote:
> >
> > adding myself as a designated reviewer.
> >
> > Signed-off-by: Peter Lieven <pl@kamp.de>
> > ---
> > MAINTAINERS | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 516db737d1..cfda57e825 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -3058,6 +3058,7 @@ F: block/vmdk.c
> >
> > RBD
> > M: Ilya Dryomov <idryomov@gmail.com>
> > +R: Peter Lieven <pl@kamp.de>
> > L: qemu-block@nongnu.org
> > S: Supported
> > F: block/rbd.c
>
> Nit: I would change the title to "MAINTAINERS: add block/rbd.c reviewer"
> or something like that.
Yes, this is better. I've changed it in my queue.
Kevin
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] block/rbd: fix type of task->complete
2021-07-07 18:04 [PATCH] block/rbd: fix type of task->complete Peter Lieven
2021-07-07 18:04 ` [PATCH] MAINTAINERS: update block/rbd.c maintainer Peter Lieven
@ 2021-07-07 21:51 ` Connor Kuehl
2021-07-08 10:00 ` Kevin Wolf
2021-07-08 10:41 ` Ilya Dryomov
2 siblings, 1 reply; 7+ messages in thread
From: Connor Kuehl @ 2021-07-07 21:51 UTC (permalink / raw)
To: Peter Lieven, qemu-block
Cc: kwolf, berrange, qemu-devel, ct, mreitz, pbonzini, idryomov,
idryomov, dillaman
On 7/7/21 11:04 AM, Peter Lieven wrote:
> task->complete is a bool not an integer.
>
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
> block/rbd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/rbd.c b/block/rbd.c
> index 01a7b94d62..dcf82b15b8 100644
> --- a/block/rbd.c
> +++ b/block/rbd.c
> @@ -1066,7 +1066,7 @@ static int qemu_rbd_resize(BlockDriverState *bs, uint64_t size)
> static void qemu_rbd_finish_bh(void *opaque)
> {
> RBDTask *task = opaque;
> - task->complete = 1;
> + task->complete = true;
> aio_co_wake(task->co);
> }
>
>
Hi Peter,
What tree/QEMU git sha does this apply to? I am having trouble
finding definitions for RBDTask and qemu_rbd_finish_bh; and the
patch won't apply to my few-minutes-old clone of upstream.
Connor
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] block/rbd: fix type of task->complete
2021-07-07 21:51 ` [PATCH] block/rbd: fix type of task->complete Connor Kuehl
@ 2021-07-08 10:00 ` Kevin Wolf
0 siblings, 0 replies; 7+ messages in thread
From: Kevin Wolf @ 2021-07-08 10:00 UTC (permalink / raw)
To: Connor Kuehl
Cc: berrange, qemu-block, Peter Lieven, qemu-devel, ct, mreitz,
pbonzini, idryomov, idryomov, dillaman
Am 07.07.2021 um 23:51 hat Connor Kuehl geschrieben:
> On 7/7/21 11:04 AM, Peter Lieven wrote:
> > task->complete is a bool not an integer.
> >
> > Signed-off-by: Peter Lieven <pl@kamp.de>
> > ---
> > block/rbd.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/block/rbd.c b/block/rbd.c
> > index 01a7b94d62..dcf82b15b8 100644
> > --- a/block/rbd.c
> > +++ b/block/rbd.c
> > @@ -1066,7 +1066,7 @@ static int qemu_rbd_resize(BlockDriverState *bs, uint64_t size)
> > static void qemu_rbd_finish_bh(void *opaque)
> > {
> > RBDTask *task = opaque;
> > - task->complete = 1;
> > + task->complete = true;
> > aio_co_wake(task->co);
> > }
> >
> >
>
> Hi Peter,
>
> What tree/QEMU git sha does this apply to? I am having trouble
> finding definitions for RBDTask and qemu_rbd_finish_bh; and the
> patch won't apply to my few-minutes-old clone of upstream.
It is on top of:
[PATCH v5 0/6] block/rbd: migrate to coroutines and add write zeroes support
Message-Id: <20210702172356.11574-1-idryomov@gmail.com>
Also, thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] block/rbd: fix type of task->complete
2021-07-07 18:04 [PATCH] block/rbd: fix type of task->complete Peter Lieven
2021-07-07 18:04 ` [PATCH] MAINTAINERS: update block/rbd.c maintainer Peter Lieven
2021-07-07 21:51 ` [PATCH] block/rbd: fix type of task->complete Connor Kuehl
@ 2021-07-08 10:41 ` Ilya Dryomov
2 siblings, 0 replies; 7+ messages in thread
From: Ilya Dryomov @ 2021-07-08 10:41 UTC (permalink / raw)
To: Peter Lieven
Cc: Kevin Wolf, Daniel P. Berrangé, qemu-block, ct, qemu-devel,
Paolo Bonzini, Max Reitz, Jason Dillaman
On Wed, Jul 7, 2021 at 8:05 PM Peter Lieven <pl@kamp.de> wrote:
>
> task->complete is a bool not an integer.
>
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
> block/rbd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/rbd.c b/block/rbd.c
> index 01a7b94d62..dcf82b15b8 100644
> --- a/block/rbd.c
> +++ b/block/rbd.c
> @@ -1066,7 +1066,7 @@ static int qemu_rbd_resize(BlockDriverState *bs, uint64_t size)
> static void qemu_rbd_finish_bh(void *opaque)
> {
> RBDTask *task = opaque;
> - task->complete = 1;
> + task->complete = true;
> aio_co_wake(task->co);
> }
>
> --
> 2.17.1
>
>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Thanks,
Ilya
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-07-08 12:08 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-07 18:04 [PATCH] block/rbd: fix type of task->complete Peter Lieven
2021-07-07 18:04 ` [PATCH] MAINTAINERS: update block/rbd.c maintainer Peter Lieven
2021-07-08 10:44 ` Ilya Dryomov
2021-07-08 12:06 ` Kevin Wolf
2021-07-07 21:51 ` [PATCH] block/rbd: fix type of task->complete Connor Kuehl
2021-07-08 10:00 ` Kevin Wolf
2021-07-08 10:41 ` Ilya Dryomov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).