qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Cole Robinson <crobinso@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] Move qemu.sasl to contrib/
Date: Thu, 8 Jul 2021 19:45:31 +0100	[thread overview]
Message-ID: <YOdHyyEGzWzMWC0H@redhat.com> (raw)
In-Reply-To: <d1a1e265dd846de6ca40406300d91cecfba69ef8.1625769570.git.crobinso@redhat.com>

On Thu, Jul 08, 2021 at 02:39:57PM -0400, Cole Robinson wrote:
> It's not installed in any way, so seems like contrib/ material

Not really.

Contrib is stuff that is included on an ad-hoc basis with no
commitment to support and no guarantee that it is working at
all.  Yes, there is some stuff in contrib/ that doesn't
belong there based on this definition, and should be moved
out.

The SASL config is most definitely supported, so doesn't
belong in there.

> 
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
> Or should this be installed to /etc/sasl2 ?
> 
>  MAINTAINERS                    | 2 +-
>  qemu.sasl => contrib/qemu.sasl | 0
>  2 files changed, 1 insertion(+), 1 deletion(-)
>  rename qemu.sasl => contrib/qemu.sasl (100%)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 684142e12e..2ec1c362f0 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2768,7 +2768,7 @@ F: tests/unit/test-crypto-*
>  F: tests/bench/benchmark-crypto-*
>  F: tests/unit/crypto-tls-*
>  F: tests/unit/pkix_asn1_tab.c
> -F: qemu.sasl
> +F: contrib/qemu.sasl
>  
>  Coroutines
>  M: Stefan Hajnoczi <stefanha@redhat.com>
> diff --git a/qemu.sasl b/contrib/qemu.sasl
> similarity index 100%
> rename from qemu.sasl
> rename to contrib/qemu.sasl
> -- 
> 2.31.1
> 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2021-07-08 19:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-08 18:39 [PATCH] Move qemu.sasl to contrib/ Cole Robinson
2021-07-08 18:45 ` Daniel P. Berrangé [this message]
2021-07-08 19:18   ` Peter Maydell
2021-07-08 20:49     ` Cole Robinson
2021-07-08 23:22       ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YOdHyyEGzWzMWC0H@redhat.com \
    --to=berrange@redhat.com \
    --cc=crobinso@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).