From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65026C07E96 for ; Thu, 8 Jul 2021 19:13:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 200FB61629 for ; Thu, 8 Jul 2021 19:13:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 200FB61629 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34222 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1ZT5-0002KV-6R for qemu-devel@archiver.kernel.org; Thu, 08 Jul 2021 15:13:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43874) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1Z1t-0005LP-AR for qemu-devel@nongnu.org; Thu, 08 Jul 2021 14:45:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:38342) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1Z1p-0005q9-8B for qemu-devel@nongnu.org; Thu, 08 Jul 2021 14:45:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625769939; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=MhDvBP7MGiLJaXCD1J3o+IeBcoQlotjFhKGYHN76s38=; b=Pa5jizw6sOkcSguGjJ+PIorr5xj0ByioqpvGA6/TWB4KMl2I1P7ZDz0qqFnNneKyVp+qeX HYKqpQv15Ip26MW11MmMwXrp9hV2BJP1o4TVwgfg3r21JoLxaM4dwPB4qHJ98tqbwFo9Rc msxUpOlrGDdthX0S1R1TtLme03guQZs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-266-HvkQy2YpOS2pz8qQoryghA-1; Thu, 08 Jul 2021 14:45:36 -0400 X-MC-Unique: HvkQy2YpOS2pz8qQoryghA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4F14780431F for ; Thu, 8 Jul 2021 18:45:35 +0000 (UTC) Received: from redhat.com (ovpn-114-169.ams2.redhat.com [10.36.114.169]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7446E19D9F; Thu, 8 Jul 2021 18:45:34 +0000 (UTC) Date: Thu, 8 Jul 2021 19:45:31 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Cole Robinson Subject: Re: [PATCH] Move qemu.sasl to contrib/ Message-ID: References: MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.0.7 (2021-05-04) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.45, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Jul 08, 2021 at 02:39:57PM -0400, Cole Robinson wrote: > It's not installed in any way, so seems like contrib/ material Not really. Contrib is stuff that is included on an ad-hoc basis with no commitment to support and no guarantee that it is working at all. Yes, there is some stuff in contrib/ that doesn't belong there based on this definition, and should be moved out. The SASL config is most definitely supported, so doesn't belong in there. > > Signed-off-by: Cole Robinson > --- > Or should this be installed to /etc/sasl2 ? > > MAINTAINERS | 2 +- > qemu.sasl => contrib/qemu.sasl | 0 > 2 files changed, 1 insertion(+), 1 deletion(-) > rename qemu.sasl => contrib/qemu.sasl (100%) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 684142e12e..2ec1c362f0 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2768,7 +2768,7 @@ F: tests/unit/test-crypto-* > F: tests/bench/benchmark-crypto-* > F: tests/unit/crypto-tls-* > F: tests/unit/pkix_asn1_tab.c > -F: qemu.sasl > +F: contrib/qemu.sasl > > Coroutines > M: Stefan Hajnoczi > diff --git a/qemu.sasl b/contrib/qemu.sasl > similarity index 100% > rename from qemu.sasl > rename to contrib/qemu.sasl > -- > 2.31.1 > Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|