From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Dongwon Kim <dongwon.kim@intel.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 1/3] ui/gtk: adds status bar for expressing ups and fps
Date: Tue, 27 Jul 2021 09:24:44 +0100 [thread overview]
Message-ID: <YP/CzA+IvMpeTgQh@redhat.com> (raw)
In-Reply-To: <20210726222551.28795-1-dongwon.kim@intel.com>
On Mon, Jul 26, 2021 at 03:25:49PM -0700, Dongwon Kim wrote:
> With a display option, "show-fps=on", qemu adds a status bar and print
> following performance numbers on the bar,
>
> ups = update per seconds - the rate the guest scanout is updated.
> fps = frame per seconds - the frame rate of VC's GL drawing area
>
> One function, gd_gl_count_frame is added to count # frames
> and calculate ups and fps every 100 frames or guest scanout updates.
This feels like a pretty niche/novelty feature. Is this really
something we can justify adding to the UI, considering that it
means we will be maintaining this UI and supporting code long
term.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2021-07-27 8:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 22:25 [PATCH 1/3] ui/gtk: adds status bar for expressing ups and fps Dongwon Kim
2021-07-26 22:25 ` [PATCH 2/3] ui/gtk: calling gd_gl_frame_counter at every draw/swap Dongwon Kim
2021-07-26 22:25 ` [PATCH 3/3] virtio-gpu: call dpy_gl_frame_counter at every guest scanout flush Dongwon Kim
2021-07-27 8:24 ` Daniel P. Berrangé [this message]
2021-07-27 18:46 ` [PATCH 1/3] ui/gtk: adds status bar for expressing ups and fps Dongwon Kim
2021-07-29 23:47 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YP/CzA+IvMpeTgQh@redhat.com \
--to=berrange@redhat.com \
--cc=dongwon.kim@intel.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).