From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CCDBC4338F for ; Tue, 27 Jul 2021 08:26:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC65261057 for ; Tue, 27 Jul 2021 08:26:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EC65261057 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:36808 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m8IPp-0005Sj-Qx for qemu-devel@archiver.kernel.org; Tue, 27 Jul 2021 04:26:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41408) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m8IOc-0004mu-0X for qemu-devel@nongnu.org; Tue, 27 Jul 2021 04:25:02 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:25309) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m8IOX-0005pR-GZ for qemu-devel@nongnu.org; Tue, 27 Jul 2021 04:25:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627374295; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=pICfI16rvnb4Y8iwHH0l2GbLTp6kTg9P2LdXlNfF2PE=; b=gX4grg6vxO2MIUu/9LoGOPi6rdSi2o2pVTujFRTd7OdpyViyHSlu0R0gKtcSVf86+pzq/y KM/LYhSrct3JcPx6vWg6bO1nCKBTwLFpMfpuTUfsVW+FhqEIOD5BVMIgpO3NQJiojWExNj L1lUE+q9nOJE5uTu8tnSbPAEsXLSaQ4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-233-oJM2EVWwMCGg2L9cK09emA-1; Tue, 27 Jul 2021 04:24:49 -0400 X-MC-Unique: oJM2EVWwMCGg2L9cK09emA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3679418C8C3C; Tue, 27 Jul 2021 08:24:48 +0000 (UTC) Received: from redhat.com (ovpn-113-151.ams2.redhat.com [10.36.113.151]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 77DDF5C1CF; Tue, 27 Jul 2021 08:24:47 +0000 (UTC) Date: Tue, 27 Jul 2021 09:24:44 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Dongwon Kim Subject: Re: [PATCH 1/3] ui/gtk: adds status bar for expressing ups and fps Message-ID: References: <20210726222551.28795-1-dongwon.kim@intel.com> MIME-Version: 1.0 In-Reply-To: <20210726222551.28795-1-dongwon.kim@intel.com> User-Agent: Mutt/2.0.7 (2021-05-04) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.717, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Jul 26, 2021 at 03:25:49PM -0700, Dongwon Kim wrote: > With a display option, "show-fps=on", qemu adds a status bar and print > following performance numbers on the bar, > > ups = update per seconds - the rate the guest scanout is updated. > fps = frame per seconds - the frame rate of VC's GL drawing area > > One function, gd_gl_count_frame is added to count # frames > and calculate ups and fps every 100 frames or guest scanout updates. This feels like a pretty niche/novelty feature. Is this really something we can justify adding to the UI, considering that it means we will be maintaining this UI and supporting code long term. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|