From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, thuth@redhat.com, peterx@redhat.com,
berrange@redhat.com, quintela@redhat.com
Subject: Re: [PATCH] tests/qtest/migration-test.c: use 127.0.0.1 instead of 0
Date: Mon, 26 Jul 2021 12:26:28 +0100 [thread overview]
Message-ID: <YP6b5KJ8SuHFnIWU@work-vm> (raw)
In-Reply-To: <20210719185217.122105-1-dgilbert@redhat.com>
* Dr. David Alan Gilbert (git) (dgilbert@redhat.com) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> OpenBSD doesn't like :0 as an address, switch to using 127.0.0.1
> in baddest; it's really testing the :0 port number that isn't allowed
> on anything.
>
> (The test doesn't currently run anyway because of the userfault
> problem that Peter noticed, but this gets us closer to being able to
> reenable it)
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Queued
> ---
> tests/qtest/migration-test.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
> index 328d6dbe97..1e8b7784ef 100644
> --- a/tests/qtest/migration-test.c
> +++ b/tests/qtest/migration-test.c
> @@ -787,10 +787,10 @@ static void test_baddest(void)
>
> args->hide_stderr = true;
>
> - if (test_migrate_start(&from, &to, "tcp:0:0", args)) {
> + if (test_migrate_start(&from, &to, "tcp:127.0.0.1:0", args)) {
> return;
> }
> - migrate_qmp(from, "tcp:0:0", "{}");
> + migrate_qmp(from, "tcp:127.0.0.1:0", "{}");
> wait_for_migration_fail(from, false);
> test_migrate_end(from, to, false);
> }
> --
> 2.31.1
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
prev parent reply other threads:[~2021-07-26 11:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-19 18:52 [PATCH] tests/qtest/migration-test.c: use 127.0.0.1 instead of 0 Dr. David Alan Gilbert (git)
2021-07-19 19:43 ` Peter Xu
2021-07-19 22:16 ` Daniel P. Berrangé
2021-07-20 8:04 ` Juan Quintela
2021-07-20 11:44 ` Philippe Mathieu-Daudé
2021-07-26 11:26 ` Dr. David Alan Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YP6b5KJ8SuHFnIWU@work-vm \
--to=dgilbert@redhat.com \
--cc=berrange@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).