qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: "Willian Rampazzo" <willianr@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	qemu-devel@nongnu.org,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [PATCH] gitlab-ci: Remove the second superfluous macos task
Date: Mon, 19 Jul 2021 10:04:34 +0100	[thread overview]
Message-ID: <YPVAInhYVnDvOf+c@redhat.com> (raw)
In-Reply-To: <20210719073051.1559348-1-thuth@redhat.com>

On Mon, Jul 19, 2021 at 09:30:51AM +0200, Thomas Huth wrote:
> While there might have been bigger differnces between the -base and
> the -xcode images in the beginning, they almost vanished in the
> current builds, e.g. when comparing the output of the "configure"
> step after cleaning up the differences due to temporary path names,
> I only get:
> 
> $ diff -u /tmp/base.txt /tmp/xcode.txt
> --- /tmp/base.txt	2021-07-16 09:16:24.211427940 +0200
> +++ /tmp/xcode.txt	2021-07-16 09:16:43.029684274 +0200
> @@ -19,14 +19,14 @@
>  Build type: native build
>  Project name: qemu
>  Project version: 6.0.50
> -C compiler for the host machine: cc (clang 12.0.0 "Apple clang version 12.0.0 (clang-1200.0.32.29)")
> +C compiler for the host machine: cc (clang 12.0.0 "Apple clang version 12.0.0 (clang-1200.0.32.28)")
>  C linker for the host machine: cc ld64 609.8
>  Host machine cpu family: x86_64
>  Host machine cpu: x86_64
>  Program sh found: YES (/bin/sh)
>  Program python3 found: YES (/usr/local/opt/python@3.9/bin/python3.9)
>  Program bzip2 found: YES (/usr/bin/bzip2)
> -C++ compiler for the host machine: c++ (clang 12.0.0 "Apple clang version 12.0.0 (clang-1200.0.32.29)")
> +C++ compiler for the host machine: c++ (clang 12.0.0 "Apple clang version 12.0.0 (clang-1200.0.32.28)")
>  C++ linker for the host machine: c++ ld64 609.8
>  Objective-C compiler for the host machine: clang (clang 12.0.0)
>  Objective-C linker for the host machine: clang ld64 609.8
> 
> Since we're not using Xcode itself at all, it seems like it does not
> make much sense anymore to waste compute cycles with two images here.
> Thus let's delete the -xcode job now.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  .gitlab-ci.d/cirrus.yml | 15 ---------------
>  1 file changed, 15 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


We can always add it back easily later if it becomes relevant again in
a future release/update.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2021-07-19  9:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-19  7:30 [PATCH] gitlab-ci: Remove the second superfluous macos task Thomas Huth
2021-07-19  9:04 ` Daniel P. Berrangé [this message]
2021-07-20 18:04 ` Willian Rampazzo
2021-07-20 22:15 ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YPVAInhYVnDvOf+c@redhat.com \
    --to=berrange@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    --cc=willianr@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).