* [PATCH] chardev-spice: add missing module_obj directive
@ 2021-07-19 16:44 Paolo Bonzini
2021-07-19 17:35 ` Daniel P. Berrangé
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2021-07-19 16:44 UTC (permalink / raw)
To: qemu-devel; +Cc: Frederic Bezies, kraxel
The chardev-spicevmc class was not listed in chardev/spice.c, causing
"-chardev spicevmc" to fail when modules are enabled.
Reported-by: Frederic Bezies <fredbezies@gmail.com>
Fixes: 9f4a0f0978 ("modules: use modinfo for qom load", 2021-07-09)
Resolves: #488
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
chardev/spice.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/chardev/spice.c b/chardev/spice.c
index 3ffb3fdc0d..bbffef4913 100644
--- a/chardev/spice.c
+++ b/chardev/spice.c
@@ -382,6 +382,7 @@ static const TypeInfo char_spicevmc_type_info = {
.parent = TYPE_CHARDEV_SPICE,
.class_init = char_spicevmc_class_init,
};
+module_obj(TYPE_CHARDEV_SPICEVMC);
static void char_spiceport_class_init(ObjectClass *oc, void *data)
{
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] chardev-spice: add missing module_obj directive
2021-07-19 16:44 [PATCH] chardev-spice: add missing module_obj directive Paolo Bonzini
@ 2021-07-19 17:35 ` Daniel P. Berrangé
0 siblings, 0 replies; 2+ messages in thread
From: Daniel P. Berrangé @ 2021-07-19 17:35 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Frederic Bezies, qemu-devel, kraxel
On Mon, Jul 19, 2021 at 12:44:35PM -0400, Paolo Bonzini wrote:
> The chardev-spicevmc class was not listed in chardev/spice.c, causing
> "-chardev spicevmc" to fail when modules are enabled.
>
> Reported-by: Frederic Bezies <fredbezies@gmail.com>
> Fixes: 9f4a0f0978 ("modules: use modinfo for qom load", 2021-07-09)
> Resolves: #488
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> chardev/spice.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-19 17:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-19 16:44 [PATCH] chardev-spice: add missing module_obj directive Paolo Bonzini
2021-07-19 17:35 ` Daniel P. Berrangé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).