From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AEBFC4338F for ; Fri, 6 Aug 2021 12:47:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF94661181 for ; Fri, 6 Aug 2021 12:47:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BF94661181 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:58706 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mBzG6-00087t-L1 for qemu-devel@archiver.kernel.org; Fri, 06 Aug 2021 08:47:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34142) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBzEX-0006xS-1K for qemu-devel@nongnu.org; Fri, 06 Aug 2021 08:45:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:58636) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBzET-0005Dy-J1 for qemu-devel@nongnu.org; Fri, 06 Aug 2021 08:45:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628253947; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tWk7Eror2WsriFeC+Kq9elwBRxemw0JH+zlqyc1UzjU=; b=bkkNqU3Sz6Wb0udJUdLL5dSv9d7OsXac8xcdclcF+xBtX3Xd7Q9FMN8iz5EtSwCFlHRAZ7 mGQzA+oP2hpxlWze38mYELglvruGhtNpsl+qh86UoYGO65HLaNJGjOBzHGXHjrOUQf84zV xssRV0v2qCMAD96UrrMDQwGkEFD//hU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-587-rfeIVV4vNt-3XsLBdGPpHw-1; Fri, 06 Aug 2021 08:45:35 -0400 X-MC-Unique: rfeIVV4vNt-3XsLBdGPpHw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 69EB01084F4C; Fri, 6 Aug 2021 12:45:34 +0000 (UTC) Received: from redhat.com (unknown [10.39.194.63]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 54C78781EB; Fri, 6 Aug 2021 12:45:32 +0000 (UTC) Date: Fri, 6 Aug 2021 13:45:29 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Eduardo Habkost Subject: Re: [PATCH] bcm2836: Remove redundant typedef and macros Message-ID: References: <20210805214739.390613-1-ehabkost@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210805214739.390613-1-ehabkost@redhat.com> User-Agent: Mutt/2.0.7 (2021-05-04) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.7, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Peter Maydell , qemu-devel@nongnu.org, Andrew Baumann , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, Paolo Bonzini , Luc Michel Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Aug 05, 2021 at 05:47:39PM -0400, Eduardo Habkost wrote: > commit 58b350280e97 ("hw/arm/bcm2836: Restrict BCM283XInfo > declaration to C source") didn't just move the struct > BCM283XClass definition to bcm2836.c. It also introduced a > typedef (BCM283XClass) and two type checking macros > (BCM283X_CLASS, BCM283X_GET_CLASS). > > The typedef and macros duplicate what is already defined by the > OBJECT_DECLARE_TYPE declaration at bcm2836.h. Remove the > redundant declarations. > > Signed-off-by: Eduardo Habkost > --- > Cc: Philippe Mathieu-Daudé > Cc: Luc Michel > Cc: Peter Maydell > --- > hw/arm/bcm2836.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) Reviewed-by: Daniel P. Berrangé Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|