From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89681C4338F for ; Tue, 27 Jul 2021 15:48:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0309761B52 for ; Tue, 27 Jul 2021 15:48:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0309761B52 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:44518 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m8PJL-0006dc-S2 for qemu-devel@archiver.kernel.org; Tue, 27 Jul 2021 11:48:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60942) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m8PIG-0004ro-PT for qemu-devel@nongnu.org; Tue, 27 Jul 2021 11:46:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:28036) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m8PID-00026m-TF for qemu-devel@nongnu.org; Tue, 27 Jul 2021 11:46:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627400812; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vOUllnqBIPKWvajp0U3nBWoh0YnL1hHFp+m4UrvoVv4=; b=SJ88w5LJoxTKs5POeyqzzI/3E03wBMOAfp3VPc0VCF4WITfTH8TqQlZx4Ga3MKHSdlgcrA asEXSlCoPReS+Is+1LF08CGabXCTVMXUAoA8xD6cb3Rbdkd6tD5000V9tCiQ1j70rcZ3Qd 9I0HUUa/+Zyyo/ogvFnJR1ab+DhdpPg= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-234-zOSWevMwP4aTwxLr18WqhA-1; Tue, 27 Jul 2021 11:46:49 -0400 X-MC-Unique: zOSWevMwP4aTwxLr18WqhA-1 Received: by mail-qv1-f72.google.com with SMTP id gg10-20020a056214252ab02902f3a4c41d77so10859705qvb.18 for ; Tue, 27 Jul 2021 08:46:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=vOUllnqBIPKWvajp0U3nBWoh0YnL1hHFp+m4UrvoVv4=; b=VDZoHdLBYKMUOJk5QIgiPdFhQijtovt5hgBXsjx/6MK2lSTeCvEjbRrFHvZhYMcqX5 QBO3GP+uElJ7WEJfGzJXYRFAm2vQ0hTTh155UyjcD1Hrr45mJUjoIeYYDxvaqdW0hv9F fMWuPlkYGGVvysxNhWMjkLfnQOl2bPHnwocD9usmT0B1aFZOQSWcDdJT4gu3uJfcLfJu U1fruLe9iVj1NGHUUzGAZ7pFjwA1YxK8656G5obQcDIxMVjT3Q+y7w8PlgY8jIVsnp6A Oyq0wSRlmGc1d5j1jSPyiU4nQ2G/8d/7rpDBMf9+HP8HtgpyEqH1EJAfJFZrpp1Kwx4F Q2Iw== X-Gm-Message-State: AOAM531rC71vIfu2DfWfh5g8jlwU7Qk7F2El4IthVu97LOfSyq0haLc9 0gOiKUbNMKuKzzoBD2ZtuQ/nNV1ZPp0xG4QyfvQ+E9tPnGy5LMA0S19qGU2ex0zNz1g13WnbhR4 +5ZWZbW73AouSmI8= X-Received: by 2002:a05:622a:254:: with SMTP id c20mr19758384qtx.324.1627400808994; Tue, 27 Jul 2021 08:46:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwuJXqqFO547LXxIXSZHBFQ4mbuKMmUV+LUVsze66aOwpMKKwcd0NiRbqipPhjCSH7mDg+vmA== X-Received: by 2002:a05:622a:254:: with SMTP id c20mr19758358qtx.324.1627400808791; Tue, 27 Jul 2021 08:46:48 -0700 (PDT) Received: from t490s (bras-base-toroon474qw-grc-65-184-144-111-238.dsl.bell.ca. [184.144.111.238]) by smtp.gmail.com with ESMTPSA id q9sm1832963qkj.28.2021.07.27.08.46.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jul 2021 08:46:48 -0700 (PDT) Date: Tue, 27 Jul 2021 11:46:46 -0400 From: Peter Xu To: David Hildenbrand Subject: Re: [PATCH v4 1/4] tpm: mark correct memory region range dirty when clearing RAM Message-ID: References: <20210727082545.17934-1-david@redhat.com> <20210727082545.17934-2-david@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210727082545.17934-2-david@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.717, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Eduardo Habkost , "Michael S. Tsirkin" , Stefan Berger , qemu-devel@nongnu.org, "Dr . David Alan Gilbert" , Alex Williamson , Claudio Fontana , Paolo Bonzini , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Alex =?utf-8?Q?Benn=C3=A9e?= , Igor Mammedov , Stefan Berger Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Jul 27, 2021 at 10:25:42AM +0200, David Hildenbrand wrote: > We might not start at the beginning of the memory region. Let's > calculate the offset into the memory region via the difference in the > host addresses. > > Acked-by: Stefan Berger > Fixes: ffab1be70692 ("tpm: clear RAM when "memory overwrite" requested") > Cc: Marc-André Lureau > Cc: Paolo Bonzini > Cc: "Michael S. Tsirkin" > Cc: Eduardo Habkost > Cc: Alex Williamson > Cc: Dr. David Alan Gilbert > Cc: Igor Mammedov > Cc: Claudio Fontana > Cc: Thomas Huth > Cc: "Alex Bennée" > Cc: Peter Xu > Cc: Laurent Vivier > Cc: Stefan Berger > Signed-off-by: David Hildenbrand Reviewed-by: Peter Xu -- Peter Xu