From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Cleber Rosa" <crosa@redhat.com>
Subject: Re: "make check-acceptance" takes way too long
Date: Mon, 2 Aug 2021 09:38:16 +0100 [thread overview]
Message-ID: <YQeu+Jm2Q0NlQ2Im@redhat.com> (raw)
In-Reply-To: <CAFEAcA9cMZoj18gq7Ksv5PRoU1wRmXvW_e9UE73C_MEB7wTroQ@mail.gmail.com>
On Fri, Jul 30, 2021 at 04:12:27PM +0100, Peter Maydell wrote:
> "make check-acceptance" takes way way too long. I just did a run
> on an arm-and-aarch64-targets-only debug build and it took over
> half an hour, and this despite it skipping or cancelling 26 out
> of 58 tests!
>
> I think that ~10 minutes runtime is reasonable. 30 is not;
> ideally no individual test would take more than a minute or so.
>
> Output saying where the time went. The first two tests take
> more than 10 minutes *each*. I think a good start would be to find
> a way of testing what they're testing that is less heavyweight.
While there is certainly value in testing with a real world "full" guest
OS, I think it is overkill as the default setup. I reckon we would get
80-90% of the value, by making our own test image repo, containing minimal
kernel builds for each machine/target combo we need, together with a tiny
initrd containing busybox. This could easily be made to boot in 1 second,
which would make 'make check-acceptance' waaaaay faster, considering how
many times we boot a guest. This would also solve our problem that we're
pointing to URLs to download these giant images, and they're frequently
break URLs.
If we want the re-assurance of running a full guest OS, we could wire
that up 'make check-acceptance FULL_OS=1' and then set that up as a
nightly CI job to run post-merge as a sanity-check, where speed does
not matter
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2021-08-02 8:39 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 15:12 "make check-acceptance" takes way too long Peter Maydell
2021-07-30 15:41 ` Philippe Mathieu-Daudé
2021-07-30 15:42 ` Peter Maydell
2021-07-30 22:04 ` Cleber Rosa
2021-07-31 6:39 ` Thomas Huth
2021-07-31 17:58 ` Cleber Rosa
2021-07-31 18:41 ` Alex Bennée
2021-07-31 20:32 ` Peter Maydell
2021-08-02 22:55 ` Cleber Rosa
2021-08-02 8:38 ` Daniel P. Berrangé [this message]
2021-08-02 12:47 ` Alex Bennée
2021-08-02 12:59 ` Daniel P. Berrangé
2021-08-02 12:55 ` Alex Bennée
2021-08-02 13:00 ` Peter Maydell
2021-08-02 13:04 ` Daniel P. Berrangé
2021-08-02 13:25 ` Thomas Huth
2021-08-02 13:00 ` Daniel P. Berrangé
2021-08-02 13:27 ` Thomas Huth
2021-08-02 13:43 ` Gerd Hoffmann
2022-01-20 15:13 ` Peter Maydell
2022-01-20 15:35 ` Philippe Mathieu-Daudé via
2022-01-21 7:56 ` Thomas Huth
2022-01-21 10:50 ` Markus Armbruster
2022-01-21 11:33 ` Peter Maydell
2022-01-21 12:23 ` Alex Bennée
2022-01-21 12:41 ` Thomas Huth
2022-01-21 15:21 ` Daniel P. Berrangé
2022-01-25 9:20 ` Gerd Hoffmann
2022-02-01 6:31 ` Stefano Brivio
2022-02-01 7:49 ` Gerd Hoffmann
2022-02-01 9:06 ` Daniel P. Berrangé
2022-02-01 10:27 ` Stefano Brivio
2022-02-01 11:17 ` Alex Bennée
2022-02-01 16:01 ` Cleber Rosa
2022-02-01 16:19 ` Daniel P. Berrangé
2022-02-01 17:47 ` Cleber Rosa
2022-02-01 18:03 ` Alex Bennée
2022-02-01 19:04 ` Cleber Rosa
2022-02-01 18:35 ` Stefano Brivio
2022-02-01 17:59 ` Cédric Le Goater
2022-02-01 11:06 ` Kashyap Chamarthy
2022-02-01 15:54 ` Cleber Rosa
2022-02-01 5:29 ` Cleber Rosa
2022-02-01 17:01 ` Daniel P. Berrangé
2022-02-01 17:59 ` Cleber Rosa
2022-02-15 18:14 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQeu+Jm2Q0NlQ2Im@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).