qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: marcandre.lureau@redhat.com
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH v2 06/11] chardev: fix fd_chr_add_watch() when in != out
Date: Thu, 5 Aug 2021 11:38:14 +0100	[thread overview]
Message-ID: <YQu/lovrnKUTPgiE@redhat.com> (raw)
In-Reply-To: <20210804154848.557328-7-marcandre.lureau@redhat.com>

On Wed, Aug 04, 2021 at 07:48:43PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Create child sources for the different streams, and dispatch on the
> parent source with the synthesized conditions.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  chardev/char-fd.c | 78 ++++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 77 insertions(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2021-08-05 10:39 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-04 15:48 [PATCH v2 00/11] chardev related fixes marcandre.lureau
2021-08-04 15:48 ` [PATCH v2 01/11] util: fix abstract socket path copy marcandre.lureau
2021-08-04 15:48 ` [PATCH v2 02/11] chardev/socket: print a more correct command-line address marcandre.lureau
2021-08-05 10:29   ` Daniel P. Berrangé
2021-08-04 15:48 ` [PATCH v2 03/11] chardev: remove needless class method marcandre.lureau
2021-08-04 15:48 ` [PATCH v2 04/11] chardev: add some comments about the class methods marcandre.lureau
2021-08-04 15:48 ` [PATCH v2 05/11] chardev: mark explicitly first argument as poisoned marcandre.lureau
2021-08-05 10:36   ` Daniel P. Berrangé
2021-08-05 10:39     ` Marc-André Lureau
2021-08-05 10:43       ` Daniel P. Berrangé
2021-08-04 15:48 ` [PATCH v2 06/11] chardev: fix fd_chr_add_watch() when in != out marcandre.lureau
2021-08-05 10:38   ` Daniel P. Berrangé [this message]
2021-08-04 15:48 ` [PATCH v2 07/11] chardev: fix qemu_chr_open_fd() being called with fd=-1 marcandre.lureau
2021-08-05 10:39   ` Daniel P. Berrangé
2021-08-04 15:48 ` [PATCH v2 08/11] chardev: fix qemu_chr_open_fd() with fd_in==fd_out marcandre.lureau
2021-08-05 10:40   ` Daniel P. Berrangé
2021-08-04 15:48 ` [PATCH v2 09/11] chardev: give some context on chardev-add error marcandre.lureau
2021-08-04 15:48 ` [PATCH v2 10/11] chardev: report a simpler error about duplicated id marcandre.lureau
2021-08-05 10:41   ` Daniel P. Berrangé
2021-08-04 15:48 ` [PATCH v2 11/11] chardev: reuse qmp_chardev_new() marcandre.lureau
2021-08-05 10:42   ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YQu/lovrnKUTPgiE@redhat.com \
    --to=berrange@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).