From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F656C4338F for ; Mon, 9 Aug 2021 10:55:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95309610E9 for ; Mon, 9 Aug 2021 10:55:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 95309610E9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=irrelevant.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:58762 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mD2w6-0002W1-8P for qemu-devel@archiver.kernel.org; Mon, 09 Aug 2021 06:55:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43366) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mD2sM-0005c6-0E; Mon, 09 Aug 2021 06:51:22 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:44021) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mD2sK-0004dS-3y; Mon, 09 Aug 2021 06:51:21 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id EF1465C0101; Mon, 9 Aug 2021 06:51:18 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 09 Aug 2021 06:51:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=96D6NZgSVUi+5OoY+JFriqSFMCM tHFN+QaEu5UHFeBc=; b=Mo9X2CGrpRFwi3qKSBAZNvzA042mOhIeDvLVb2z76+G Z2NFYfG+Td7wnPmHNtl/ao2o7ww5Ao3z5Im0fPnq7m42YqUDoCf/UQQMW5pC8CUu 82mHkTBCt5HkNf+s3JRjkBE6Bg6DOeJ36PvAECqMGmVgetNFDr4Kc0+dPwrNKYjR 7I51DmcPgBGBOlrpP52yaNme3J7ZUlyJGtsgl7L1FGgxtZei6pmQ3WAdDc9jEWzi lLh7jbQFyorLSzz6+eYpUpGEGCCNp052UqfXyAIOvQTQAx32MRKume1VZ51YJEyj aYLYtil492mAQ+rBL6ixpysKr1yUPbvmxWemUHbdvqw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=96D6NZ gSVUi+5OoY+JFriqSFMCMtHFN+QaEu5UHFeBc=; b=brZ0NHHbSErXFZfSLnCyBb 1N+laQq2KgrXGi9QyU3+7UjjBqLfHnXRpg/ar8jE2GGJuJNrC0VlbPjDM/q4gF/v dsD/hPXIBS2L39NF+GarH+hA0xxn2Y0zLXJcHO1glt7CLoPMlje6TFqN5rQuKQlA 0aLTc9DpAqYtGTZzE6sK5quxbWkMda1Y2gZc3DMez7uiFBHo6u0nm/DREiXIzl/p gA9CdtL11qhk0Zt+Lo73QCdeXu+RvIW+rXCyiSpa+/VxSQ5+E3a6qSaO6UF30raY iFn7cGFdTpzoopq9reNGPfQ6gvE5YZOCDwmtcr1BCuh4HIa18E1xz4yRv9TWwKEw == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrjeejgdefgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepmfhlrghushcu lfgvnhhsvghnuceoihhtshesihhrrhgvlhgvvhgrnhhtrdgukheqnecuggftrfgrthhtvg hrnhepjeegudffueeiteekieelkedvueelteevjeduieeludfffeejgeffhfduvdduffek necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepihhtsh esihhrrhgvlhgvvhgrnhhtrdgukh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 9 Aug 2021 06:51:17 -0400 (EDT) Date: Mon, 9 Aug 2021 12:51:15 +0200 From: Klaus Jensen To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH-for-6.1?] hw/nvme: fix missing variable initializers Message-ID: References: <20210809104324.49434-1-its@irrelevant.dk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EGKZkRbIk1cPErNJ" Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=66.111.4.27; envelope-from=its@irrelevant.dk; helo=out3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Keith Busch , Peter Maydell , qemu-devel@nongnu.org, qemu-block@nongnu.org, Klaus Jensen Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --EGKZkRbIk1cPErNJ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Aug 9 12:47, Philippe Mathieu-Daud=C3=A9 wrote: > On 8/9/21 12:43 PM, Klaus Jensen wrote: > > From: Klaus Jensen > >=20 > > Coverity found that 'uuid', 'csi' and 'eui64' are uninitialized. While > > we set most of the fields, we do not explicitly set the rsvd2 field in > > the NvmeIdNsDescr header. > >=20 > > Fix this by explicitly zero-initializing the variables. > >=20 > > Reported-by: Coverity (CID 1458835, 1459295 and 1459580) > > Fixes: 6870cfb8140d ("hw/nvme: namespace parameter for EUI-64") > > Suggested-by: Peter Maydell > > Signed-off-by: Klaus Jensen > > --- > > hw/nvme/ctrl.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > Reviewed-by: Philippe Mathieu-Daud=C3=A9 >=20 Swift as always Philippe, thanks! Yes, I'll PR this for -rc3 immediately. --EGKZkRbIk1cPErNJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUigzqnXi3OaiR2bATeGvMW1PDekFAmERCKIACgkQTeGvMW1P DelbSgf9GQyX0l1rrTBzzeaGUov/pQeHgUC0iB5ckX+o/hhaAd701eYFbljflxJ1 Vwdo9IQtvzS+SPsH40lZ8MfOZk35XIVrU4jLWHntqJjUAKxaXybtHsEont2Jzt2V HVAGhcnSIXtgC1sNpGMODKS9yIohcWD5spK+t0Sl85Ey5tDybyfr6BeJZiwbqyWZ cj9O0Rz/sBwrNzNVHgckWmB6e9oqAVMySDZTwGLIANdtz+RXKtalYm212bbUB2wi Xi4ja108GH6j0N4n5cTqHtFzylEGXLalX2Te5rZczJ7stWtmlDeOEYQ8mRiJf7nz Ow4QvTM4XG/XWD2jx6g8XrOIFM9wjA== =f/FA -----END PGP SIGNATURE----- --EGKZkRbIk1cPErNJ--