From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E1FFC4338F for ; Tue, 10 Aug 2021 01:02:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 791E660E52 for ; Tue, 10 Aug 2021 01:02:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 791E660E52 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:45242 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDG9x-0004sp-1Y for qemu-devel@archiver.kernel.org; Mon, 09 Aug 2021 21:02:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52962) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDG6s-0003AC-F5; Mon, 09 Aug 2021 20:59:14 -0400 Received: from bilbo.ozlabs.org ([2401:3900:2:1::2]:57917 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDG6p-00083B-TX; Mon, 09 Aug 2021 20:59:14 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 4GkF2f1vrDz9tjw; Tue, 10 Aug 2021 10:59:06 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1628557146; bh=UcxMu/iPtID5Z0Pw0L1Pm9Gqy7oONcjhrKnXH3oqr7I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=m+bo1FCsCD6TclJgFjhhfyrlj5VYCXkRw1fXFGs6Jh48byibyzP4+qeHcwX3AcfbR TWBYnMzRKN1vFsVmV3Ssh/stX2wicNzAHK7Ng2SJCHn2fj5GnkmK1V19aW5lAXNbyc vctI5jerizupVsljzlxRLTEZAIjtshValG4D6Q7U= Date: Tue, 10 Aug 2021 10:56:31 +1000 From: David Gibson To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PATCH] xive: Remove extra '0x' prefix in trace events Message-ID: References: <20210809085227.288523-1-clg@kaod.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bDF+Z4T4zqQ9aqPa" Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=2401:3900:2:1::2; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.248, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, thuth@redhat.com, qemu-ppc@nongnu.org, =?iso-8859-1?Q?C=E9dric?= Le Goater , Greg Kurz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --bDF+Z4T4zqQ9aqPa Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 09, 2021 at 11:39:49AM +0200, Philippe Mathieu-Daud=E9 wrote: > On 8/9/21 10:52 AM, C=E9dric Le Goater wrote: > > Cc: thuth@redhat.com > > Fixes: 4e960974d4ee ("xive: Add trace events") > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/519 > > Signed-off-by: C=E9dric Le Goater > > --- > > hw/intc/trace-events | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > >=20 > > diff --git a/hw/intc/trace-events b/hw/intc/trace-events > > index e56e7dd3b667..6a17d38998d9 100644 > > --- a/hw/intc/trace-events > > +++ b/hw/intc/trace-events > > @@ -219,14 +219,14 @@ kvm_xive_source_reset(uint32_t srcno) "IRQ 0x%x" > > xive_tctx_accept(uint32_t index, uint8_t ring, uint8_t ipb, uint8_t pi= pr, uint8_t cppr, uint8_t nsr) "target=3D%d ring=3D0x%x IBP=3D0x%02x PIPR= =3D0x%02x CPPR=3D0x%02x NSR=3D0x%02x ACK" > > xive_tctx_notify(uint32_t index, uint8_t ring, uint8_t ipb, uint8_t pi= pr, uint8_t cppr, uint8_t nsr) "target=3D%d ring=3D0x%x IBP=3D0x%02x PIPR= =3D0x%02x CPPR=3D0x%02x NSR=3D0x%02x raise !" > > xive_tctx_set_cppr(uint32_t index, uint8_t ring, uint8_t ipb, uint8_t = pipr, uint8_t cppr, uint8_t nsr) "target=3D%d ring=3D0x%x IBP=3D0x%02x PIPR= =3D0x%02x new CPPR=3D0x%02x NSR=3D0x%02x" > > -xive_source_esb_read(uint64_t addr, uint32_t srcno, uint64_t value) "@= 0x0x%"PRIx64" IRQ 0x%x val=3D0x0x%"PRIx64 > > -xive_source_esb_write(uint64_t addr, uint32_t srcno, uint64_t value) "= @0x0x%"PRIx64" IRQ 0x%x val=3D0x0x%"PRIx64 > > +xive_source_esb_read(uint64_t addr, uint32_t srcno, uint64_t value) "@= 0x%"PRIx64" IRQ 0x%x val=3D0x%"PRIx64 > > +xive_source_esb_write(uint64_t addr, uint32_t srcno, uint64_t value) "= @0x%"PRIx64" IRQ 0x%x val=3D0x%"PRIx64 > > xive_router_end_notify(uint8_t end_blk, uint32_t end_idx, uint32_t end= _data) "END 0x%02x/0x%04x -> enqueue 0x%08x" > > xive_router_end_escalate(uint8_t end_blk, uint32_t end_idx, uint8_t es= c_blk, uint32_t esc_idx, uint32_t end_data) "END 0x%02x/0x%04x -> escalate = END 0x%02x/0x%04x data 0x%08x" > > -xive_tctx_tm_write(uint64_t offset, unsigned int size, uint64_t value)= "@0x0x%"PRIx64" sz=3D%d val=3D0x%" PRIx64 > > -xive_tctx_tm_read(uint64_t offset, unsigned int size, uint64_t value) = "@0x0x%"PRIx64" sz=3D%d val=3D0x%" PRIx64 > > +xive_tctx_tm_write(uint64_t offset, unsigned int size, uint64_t value)= "@0x%"PRIx64" sz=3D%d val=3D0x%" PRIx64 > > +xive_tctx_tm_read(uint64_t offset, unsigned int size, uint64_t value) = "@0x%"PRIx64" sz=3D%d val=3D0x%" PRIx64 > > xive_presenter_notify(uint8_t nvt_blk, uint32_t nvt_idx, uint8_t ring)= "found NVT 0x%x/0x%x ring=3D0x%x" > > -xive_end_source_read(uint8_t end_blk, uint32_t end_idx, uint64_t addr)= "END 0x%x/0x%x @0x0x%"PRIx64 > > +xive_end_source_read(uint8_t end_blk, uint32_t end_idx, uint64_t addr)= "END 0x%x/0x%x @0x%"PRIx64 > > =20 > > # pnv_xive.c > > pnv_xive_ic_hw_trigger(uint64_t addr, uint64_t val) "@0x%"PRIx64" val= =3D0x%"PRIx64 > >=20 >=20 > Acceptable for 6.1 IMHO. Acceptable for, but also not vital for. I've applied this to ppc-for-6.1, but I'll probably only bother sending a PR if some more crucial fixes come along. >=20 > Reviewed-by: Philippe Mathieu-Daud=E9 >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --bDF+Z4T4zqQ9aqPa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAmERzr0ACgkQbDjKyiDZ s5KZ2A/+L135wtUOiEnvAlYAWZFu4m01BZg1+Y7GgdxpaAVGwbLo4XAEOTtFCEUA 1gD23QKRNbz0BKZrbq5OtpFk7mXdI6zHIH7ienhT0YIwzFt9L6j2KvYIt9ZfBcjY 6TM7lILVzfe74BVfhhEYjlXX2wTh5mOmHiFVu1ec/gIYSbtDaj04jVIrlEIov5WY l3iOZH50TzeA0hPiwueXXsTiAOmq9i4pNHE2/s1REEPlWOtlvdOcKiMpWmjPOJZ8 6SrsqIXdDwt7r26xOcWvcUQyhCAkVA4P/Snq+KQyt5vuvVzM4EfIGIRZXmaPmaUT cCpVclRw19XRUekkB9QuSCMmehSzW1fl9dnT446PpY/O9ZdmLco7udI19GvQcPxI HnU4h60jOfosi/ox5vjRkixCq9T9rfTcwnHl/4XzUk6bZm+8CIJRNGvqNffXpkMa yXyhl8/NiK5U09Z2cOxstYFC5uht3hUm4vRrGsSvpn/UIw3h/a56AhVPmLT7LteT E/Sv0mihwuq61ontSsDJ94aPrdi5YkS0Qto4LY7qCO+yf0Kw/TJkIYI613wd3iJO z0CYJYkRhIGro8agJ4F/GDnCH6qNIQo6MRxBTfkjH+i+WdIpZc2lLLOaU46YaZ6k QgAffK1Ft07QkgPPGvmVUxMu/ipwQFFTs2LHbaXUhwZ1ScStrek= =Po6R -----END PGP SIGNATURE----- --bDF+Z4T4zqQ9aqPa--