From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0781C4338F for ; Mon, 16 Aug 2021 13:27:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 34BA9632A9 for ; Mon, 16 Aug 2021 13:27:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 34BA9632A9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:49562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFcdw-0000Zh-2X for qemu-devel@archiver.kernel.org; Mon, 16 Aug 2021 09:27:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48420) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFcb6-0006QL-7e for qemu-devel@nongnu.org; Mon, 16 Aug 2021 09:24:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:49344) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFcb3-0002uz-VF for qemu-devel@nongnu.org; Mon, 16 Aug 2021 09:24:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629120249; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tsLbvZN9VUnH1tfOMNir260cxi+gOVMKSLI9xD9INIs=; b=K+9FnXw8HcLyS2F00gI1Kgd+Wtv3hR+0mHsEauhUFzz+ohzVwngy+vpsZC0NINf9SS5BYb usY4kkhZ/ggckzASn94u38TjuiKVd5t8cy2Qadm4M+QofrUj5pJ4on/eZL6YzAQNkehVvt mEtt22ESaceVYEeoDFE35jAS5aeJhY4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-42-Ya3C8jptOiitXO73U5XzqQ-1; Mon, 16 Aug 2021 09:24:00 -0400 X-MC-Unique: Ya3C8jptOiitXO73U5XzqQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 73F381083E80; Mon, 16 Aug 2021 13:23:59 +0000 (UTC) Received: from redhat.com (unknown [10.39.192.216]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5F1E15C23A; Mon, 16 Aug 2021 13:23:50 +0000 (UTC) Date: Mon, 16 Aug 2021 14:23:47 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Cornelia Huck Subject: Re: [PATCH 2/2] gitlab: don't run CI jobs by default on push to user forks Message-ID: References: <20210812180403.4129067-1-berrange@redhat.com> <20210812180403.4129067-3-berrange@redhat.com> <87y291u0st.fsf@redhat.com> <87v945txvn.fsf@redhat.com> <87sfz9ttlo.fsf@redhat.com> MIME-Version: 1.0 In-Reply-To: <87sfz9ttlo.fsf@redhat.com> User-Agent: Mutt/2.0.7 (2021-05-04) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.698, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Thomas Huth , qemu-devel@nongnu.org, Wainer dos Santos Moschetta , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Willian Rampazzo , Alex =?utf-8?Q?Benn=C3=A9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Aug 16, 2021 at 03:19:31PM +0200, Cornelia Huck wrote: > On Mon, Aug 16 2021, Daniel P. Berrangé wrote: > > > On Mon, Aug 16, 2021 at 01:47:08PM +0200, Cornelia Huck wrote: > >> On Mon, Aug 16 2021, Daniel P. Berrangé wrote: > >> > >> > When I'm working on changing gitlab CI rules, then I burn loads of > >> > minutes which is especially troubling - limited CI minutes will make > >> > it very hard for me to debug future CI rule changes :-( > >> > >> I hope that will not make gitlab CI a complete non-starter -- if you > >> cannot easily debug a test case that is failing, it's mostly > >> useless. We've seen too many cases where a failure could not be > >> reproduced when the test case was running locally. > > > > One of the best things about GitLab compared to what we had with > > Travis is that the build environment is 100% container based (until > > Cleber's custom runners arrived). This meant that when something > > does fail in GitLab, you can pull the container image down from > > the gitlab registry and run the build locally. You still have > > differences due to hardware or CPUs resources, but its a hell of > > alot easier to reproduce than before. This is good enough for most > > contributors in general, but not for the CI maintainers, who need > > to debug especially the CI system as it exists on GitLab. > > Correct me if I'm wrong, but I remember that some of the more > aggravating failures in particular could not be reproduced outside of > the gitlab environment, even while using the same image. There will always be some like that for sure. Some problems are very sensitive to timing issues that are affected by load or CPUs parallism, etc. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|