Re: [PATCH] include/block.h: remove outdated comment in bdrv_drained_begin

[Stefan Hajnoczi <stefanha@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1340 bytes --]

On Mon, Aug 16, 2021 at 08:23:25PM +0200, Emanuele Giuseppe Esposito wrote:
> There are a couple of errors in bdrv_drained_begin header comment:
> - block_job_pause does not exist anymore, it has been replaced
>   with job_pause in b15de82867
> - job_pause is automatically invoked as a .drained_begin callback
>   (child_job_drained_begin) by the child_job BdrvChildClass struct
>   in blockjob.c. So no additional pause should be required.
> 
> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
> ---
>  include/block/block.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/include/block/block.h b/include/block/block.h
> index 3477290f9a..1b0d05b545 100644
> --- a/include/block/block.h
> +++ b/include/block/block.h
> @@ -749,9 +749,7 @@ bool bdrv_drain_poll(BlockDriverState *bs, bool recursive,
>   * bdrv_drained_begin:
>   *
>   * Begin a quiesced section for exclusive access to the BDS, by disabling
> - * external request sources including NBD server and device model. Note that
> - * this doesn't block timers or coroutines from submitting more requests, which
> - * means block_job_pause is still necessary.
> + * external request sources including NBD server and device model.

Block jobs are worth mentioning:
"NBD server, block jobs, and device model"?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]