From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A20D4C4320A for ; Mon, 23 Aug 2021 18:57:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 604AD613BD for ; Mon, 23 Aug 2021 18:57:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 604AD613BD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:54550 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mIF8a-0006wc-Ko for qemu-devel@archiver.kernel.org; Mon, 23 Aug 2021 14:57:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45592) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIExX-0006Q6-EG for qemu-devel@nongnu.org; Mon, 23 Aug 2021 14:46:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:33570) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIExV-0006av-L5 for qemu-devel@nongnu.org; Mon, 23 Aug 2021 14:46:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629744369; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dgcXDKAurQT+ptoDJgF7FWjF/VQsVkSiv3b5oL8pe98=; b=HAVKbh0ah4fdzC87d9oj8cSpmG53wptMiIzZrXkOupN+gaxy4lQhbztwtwYuAqJa0HlK7K TguvU22FF+KWY8gSu8r6HrEPEe0u5MhmXNru0FtVQXZOMRthNWsilOcFz3C9fCD2pTA3wk kmV/CDJiytVsr8yCP0hOyzAYhSq8WdA= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-575-QygEOX_VP9GOyfWMOKK-eQ-1; Mon, 23 Aug 2021 14:46:07 -0400 X-MC-Unique: QygEOX_VP9GOyfWMOKK-eQ-1 Received: by mail-qk1-f199.google.com with SMTP id q13-20020a05620a038d00b003d38f784161so12504260qkm.8 for ; Mon, 23 Aug 2021 11:46:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=dgcXDKAurQT+ptoDJgF7FWjF/VQsVkSiv3b5oL8pe98=; b=T89GoIOGOUjn1XN9L5r1e7EV/DC/2vk8dCFxf6a8C2Rd2oWhi2BR1zlz5Zbeoapgx+ 2qCxj6Q5XqwCZHgDltBzVpDbOUv1Brkc7rgbovqKwBqVrm90+KIc4I5mfTFDBil024Bd NF0cynFT3QmfLgBfZs2bF/4wcFfy+NsiEuvoNqP0iSSpR6182yLW0TFMnFDZ+BCRckHv tzf+HaLjiXbbPqekyazHdRr1otpP1Xzuv6W4UVXY6zrsy0Ln3BcrDn0zRFYXeAiXXi8Q eelfeujZw0a29cffVVtkI7Pd5zYM4RSLh/bMXbiq3qDVaWgkOrBSVVd1/WoRio3SE92c 64mQ== X-Gm-Message-State: AOAM5337+dKNnVeh+uU3y5QYXTlZ+luVPZ1r+0C0xHURdHjz3zto2Pek 4g445Oq/wF6BW5TFRq2IyOf4NxOAaWuEis9B4Qt1ix3urcstFV5FNdpOqz1BK4dsEFE6pcqxqVP f3a14LlnqtmIgNaQ= X-Received: by 2002:a37:2dc7:: with SMTP id t190mr14654479qkh.60.1629744367014; Mon, 23 Aug 2021 11:46:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwbQJgURAHotYAeQM7S7oyJ1feNnOS+J5ZKSaeqHT9ckiabr0zM5sy5gO1BKoaZTFk1ohj0nw== X-Received: by 2002:a37:2dc7:: with SMTP id t190mr14654464qkh.60.1629744366834; Mon, 23 Aug 2021 11:46:06 -0700 (PDT) Received: from t490s ([2607:fea8:56a3:500::d413]) by smtp.gmail.com with ESMTPSA id h6sm6680680qtb.44.2021.08.23.11.46.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Aug 2021 11:46:06 -0700 (PDT) Date: Mon, 23 Aug 2021 14:46:04 -0400 From: Peter Xu To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [RFC PATCH v2 2/5] hw/intc/arm_gicv3: Check for !MEMTX_OK instead of MEMTX_ERROR Message-ID: References: <20210823164157.751807-1-philmd@redhat.com> <20210823164157.751807-3-philmd@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210823164157.751807-3-philmd@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.743, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , David Hildenbrand , Jason Wang , Li Qiang , qemu-devel@nongnu.org, Qiuhao Li , Alexander Bulekov , qemu-arm@nongnu.org, Gerd Hoffmann , Stefan Hajnoczi , Paolo Bonzini , "Edgar E . Iglesias" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Aug 23, 2021 at 06:41:54PM +0200, Philippe Mathieu-Daudé wrote: > We are going to introduce more MemTxResult bits, so it is > safer to check for !MEMTX_OK rather than MEMTX_ERROR. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Xu -- Peter Xu