From: David Gibson <david@gibson.dropbear.id.au>
To: matheus.ferst@eldorado.org.br
Cc: peter.maydell@linaro.org, richard.henderson@linaro.org,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org, groug@kaod.org
Subject: Re: [PATCH 0/2] target/ppc: Fix vextu[bhw][lr]x on big endian hosts
Date: Wed, 25 Aug 2021 13:02:11 +1000 [thread overview]
Message-ID: <YSWysymmaKYEFQX2@yekko> (raw)
In-Reply-To: <20210824201105.2303789-1-matheus.ferst@eldorado.org.br>
[-- Attachment #1: Type: text/plain, Size: 1091 bytes --]
On Tue, Aug 24, 2021 at 05:11:03PM -0300, matheus.ferst@eldorado.org.br wrote:
> From: Matheus Ferst <matheus.ferst@eldorado.org.br>
>
> The definition of struct Int128 is currently independent of the host
> endianness, causing different results when using the member s128 of
> union ppc_vsr_t in big-endian builds with CONFIG_INT128 or
> !CONFIG_INT128.
>
> The only PPC instructions that seem to be affected by this issue are the
> "Vector Extract Unsigned Byte/Halfword/Word to GPR using GPR-specified
> Left/Right-Index." Even on builds with Int128 support, however, their
> helpers give the wrong result on big-endian hosts.
>
> The first patch in this series changes the definition of struct Int128
> to allow its use in the ppc_vsr_t union. The second patch fixes the
> helper definition.
CCing Richard Henderson, who's probably the best qualified to review
these.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-08-25 4:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 20:11 [PATCH 0/2] target/ppc: Fix vextu[bhw][lr]x on big endian hosts matheus.ferst
2021-08-24 20:11 ` [PATCH 1/2] include/qemu/int128.h: define struct Int128 according to the host endianness matheus.ferst
2021-08-26 13:11 ` Peter Maydell
2021-08-26 13:14 ` Peter Maydell
2021-08-24 20:11 ` [PATCH 2/2] target/ppc: fix vextu[bhw][lr]x helpers matheus.ferst
2021-08-25 3:02 ` David Gibson
2021-08-25 3:02 ` David Gibson [this message]
2021-08-25 5:32 ` [PATCH 0/2] target/ppc: Fix vextu[bhw][lr]x on big endian hosts Philippe Mathieu-Daudé
2021-08-25 12:55 ` Mark Cave-Ayland
2021-08-26 1:28 ` Matheus K. Ferst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSWysymmaKYEFQX2@yekko \
--to=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=matheus.ferst@eldorado.org.br \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).