From: Kevin Wolf <kwolf@redhat.com>
To: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Cc: Hanna Reitz <hreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH v2] include/block.h: remove outdated comment
Date: Mon, 13 Sep 2021 13:35:19 +0200 [thread overview]
Message-ID: <YT83d0BsFlf3hZOT@redhat.com> (raw)
In-Reply-To: <20210903113800.59970-1-eesposit@redhat.com>
Am 03.09.2021 um 13:38 hat Emanuele Giuseppe Esposito geschrieben:
> There are a couple of errors in bdrv_drained_begin header comment:
> - block_job_pause does not exist anymore, it has been replaced
> with job_pause in b15de82867
> - job_pause is automatically invoked as a .drained_begin callback
> (child_job_drained_begin) by the child_job BdrvChildClass struct
> in blockjob.c. So no additional pause should be required.
>
> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2021-09-13 11:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 11:38 [PATCH v2] include/block.h: remove outdated comment Emanuele Giuseppe Esposito
2021-09-06 14:32 ` Stefan Hajnoczi
2021-09-13 11:35 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YT83d0BsFlf3hZOT@redhat.com \
--to=kwolf@redhat.com \
--cc=eesposit@redhat.com \
--cc=hreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).