From: Peter Xu <peterx@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
David Hildenbrand <david@redhat.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v6 2/2] memory: Have 'info mtree' remove duplicated Address Space information
Date: Fri, 3 Sep 2021 12:39:59 -0400 [thread overview]
Message-ID: <YTJP34IFfGAJ4oDp@t490s> (raw)
In-Reply-To: <20210903160619.699632-3-philmd@redhat.com>
On Fri, Sep 03, 2021 at 06:06:19PM +0200, Philippe Mathieu-Daudé wrote:
> Per Peter Maydell [*]:
>
> 'info mtree' monitor command was designed on the assumption that
> there's really only one or two interesting address spaces, and
> with more recent developments that's just not the case any more.
>
> Similarly about how the FlatView are sorted using a GHashTable,
> sort the AddressSpace objects to remove the duplications (AS
> using the same root MemoryRegion).
>
> This drastically reduces the output of 'info mtree' on some boards.
>
> Before:
>
> $ (echo info mtree; echo q) \
> | qemu-system-aarch64 -S -monitor stdio -M raspi3b \
> | wc -l
> 423
>
> After:
>
> $ (echo info mtree; echo q) \
> | qemu-system-aarch64 -S -monitor stdio -M raspi3b \
> | wc -l
> 106
>
> (qemu) info mtree
> address-space: I/O
> 0000000000000000-000000000000ffff (prio 0, i/o): io
>
> address-space: cpu-memory-0
> address-space: cpu-memory-1
> address-space: cpu-memory-2
> address-space: cpu-memory-3
> address-space: cpu-secure-memory-0
> address-space: cpu-secure-memory-1
> address-space: cpu-secure-memory-2
> address-space: cpu-secure-memory-3
> address-space: memory
> 0000000000000000-ffffffffffffffff (prio 0, i/o): system
> 0000000000000000-000000003fffffff (prio 0, ram): ram
> 000000003f000000-000000003fffffff (prio 1, i/o): bcm2835-peripherals
> 000000003f003000-000000003f00301f (prio 0, i/o): bcm2835-sys-timer
> 000000003f004000-000000003f004fff (prio -1000, i/o): bcm2835-txp
> 000000003f006000-000000003f006fff (prio 0, i/o): mphi
> 000000003f007000-000000003f007fff (prio 0, i/o): bcm2835-dma
> 000000003f00b200-000000003f00b3ff (prio 0, i/o): bcm2835-ic
> 000000003f00b400-000000003f00b43f (prio -1000, i/o): bcm2835-sp804
> 000000003f00b800-000000003f00bbff (prio 0, i/o): bcm2835-mbox
> 000000003f100000-000000003f1001ff (prio 0, i/o): bcm2835-powermgt
> 000000003f101000-000000003f102fff (prio 0, i/o): bcm2835-cprman
> 000000003f104000-000000003f10400f (prio 0, i/o): bcm2835-rng
> 000000003f200000-000000003f200fff (prio 0, i/o): bcm2835_gpio
> 000000003f201000-000000003f201fff (prio 0, i/o): pl011
> 000000003f202000-000000003f202fff (prio 0, i/o): bcm2835-sdhost
> 000000003f203000-000000003f2030ff (prio -1000, i/o): bcm2835-i2s
> 000000003f204000-000000003f20401f (prio -1000, i/o): bcm2835-spi0
> 000000003f205000-000000003f20501f (prio -1000, i/o): bcm2835-i2c0
> 000000003f20f000-000000003f20f07f (prio -1000, i/o): bcm2835-otp
> 000000003f212000-000000003f212007 (prio 0, i/o): bcm2835-thermal
> 000000003f214000-000000003f2140ff (prio -1000, i/o): bcm2835-spis
> 000000003f215000-000000003f2150ff (prio 0, i/o): bcm2835-aux
> 000000003f300000-000000003f3000ff (prio 0, i/o): sdhci
> 000000003f600000-000000003f6000ff (prio -1000, i/o): bcm2835-smi
> 000000003f804000-000000003f80401f (prio -1000, i/o): bcm2835-i2c1
> 000000003f805000-000000003f80501f (prio -1000, i/o): bcm2835-i2c2
> 000000003f900000-000000003f907fff (prio -1000, i/o): bcm2835-dbus
> 000000003f910000-000000003f917fff (prio -1000, i/o): bcm2835-ave0
> 000000003f980000-000000003f990fff (prio 0, i/o): dwc2
> 000000003f980000-000000003f980fff (prio 0, i/o): dwc2-io
> 000000003f981000-000000003f990fff (prio 0, i/o): dwc2-fifo
> 000000003fc00000-000000003fc00fff (prio -1000, i/o): bcm2835-v3d
> 000000003fe00000-000000003fe000ff (prio -1000, i/o): bcm2835-sdramc
> 000000003fe05000-000000003fe050ff (prio 0, i/o): bcm2835-dma-chan15
> 0000000040000000-00000000400000ff (prio 0, i/o): bcm2836-control
>
> address-space: bcm2835-dma-memory
> address-space: bcm2835-fb-memory
> address-space: bcm2835-property-memory
> address-space: dwc2
> 0000000000000000-00000000ffffffff (prio 0, i/o): bcm2835-gpu
> 0000000000000000-000000003fffffff (prio 0, ram): alias bcm2835-gpu-ram-alias[*] @ram 0000000000000000-000000003fffffff
> 0000000040000000-000000007fffffff (prio 0, ram): alias bcm2835-gpu-ram-alias[*] @ram 0000000000000000-000000003fffffff
> 000000007e000000-000000007effffff (prio 1, i/o): alias bcm2835-peripherals @bcm2835-peripherals 0000000000000000-0000000000ffffff
> 0000000080000000-00000000bfffffff (prio 0, ram): alias bcm2835-gpu-ram-alias[*] @ram 0000000000000000-000000003fffffff
> 00000000c0000000-00000000ffffffff (prio 0, ram): alias bcm2835-gpu-ram-alias[*] @ram 0000000000000000-000000003fffffff
>
> address-space: bcm2835-mbox-memory
> 0000000000000000-000000000000008f (prio 0, i/o): bcm2835-mbox
> 0000000000000010-000000000000001f (prio 0, i/o): bcm2835-fb
> 0000000000000080-000000000000008f (prio 0, i/o): bcm2835-property
>
> memory-region: ram
> 0000000000000000-000000003fffffff (prio 0, ram): ram
>
> memory-region: bcm2835-peripherals
> 000000003f000000-000000003fffffff (prio 1, i/o): bcm2835-peripherals
> 000000003f003000-000000003f00301f (prio 0, i/o): bcm2835-sys-timer
> 000000003f004000-000000003f004fff (prio -1000, i/o): bcm2835-txp
> 000000003f006000-000000003f006fff (prio 0, i/o): mphi
> 000000003f007000-000000003f007fff (prio 0, i/o): bcm2835-dma
> 000000003f00b200-000000003f00b3ff (prio 0, i/o): bcm2835-ic
> 000000003f00b400-000000003f00b43f (prio -1000, i/o): bcm2835-sp804
> 000000003f00b800-000000003f00bbff (prio 0, i/o): bcm2835-mbox
> 000000003f100000-000000003f1001ff (prio 0, i/o): bcm2835-powermgt
> 000000003f101000-000000003f102fff (prio 0, i/o): bcm2835-cprman
> 000000003f104000-000000003f10400f (prio 0, i/o): bcm2835-rng
> 000000003f200000-000000003f200fff (prio 0, i/o): bcm2835_gpio
> 000000003f201000-000000003f201fff (prio 0, i/o): pl011
> 000000003f202000-000000003f202fff (prio 0, i/o): bcm2835-sdhost
> 000000003f203000-000000003f2030ff (prio -1000, i/o): bcm2835-i2s
> 000000003f204000-000000003f20401f (prio -1000, i/o): bcm2835-spi0
> 000000003f205000-000000003f20501f (prio -1000, i/o): bcm2835-i2c0
> 000000003f20f000-000000003f20f07f (prio -1000, i/o): bcm2835-otp
> 000000003f212000-000000003f212007 (prio 0, i/o): bcm2835-thermal
> 000000003f214000-000000003f2140ff (prio -1000, i/o): bcm2835-spis
> 000000003f215000-000000003f2150ff (prio 0, i/o): bcm2835-aux
> 000000003f300000-000000003f3000ff (prio 0, i/o): sdhci
> 000000003f600000-000000003f6000ff (prio -1000, i/o): bcm2835-smi
> 000000003f804000-000000003f80401f (prio -1000, i/o): bcm2835-i2c1
> 000000003f805000-000000003f80501f (prio -1000, i/o): bcm2835-i2c2
> 000000003f900000-000000003f907fff (prio -1000, i/o): bcm2835-dbus
> 000000003f910000-000000003f917fff (prio -1000, i/o): bcm2835-ave0
> 000000003f980000-000000003f990fff (prio 0, i/o): dwc2
> 000000003f980000-000000003f980fff (prio 0, i/o): dwc2-io
> 000000003f981000-000000003f990fff (prio 0, i/o): dwc2-fifo
> 000000003fc00000-000000003fc00fff (prio -1000, i/o): bcm2835-v3d
> 000000003fe00000-000000003fe000ff (prio -1000, i/o): bcm2835-sdramc
> 000000003fe05000-000000003fe050ff (prio 0, i/o): bcm2835-dma-chan15
>
> (qemu) q
>
> [*] https://www.mail-archive.com/qemu-devel@nongnu.org/msg829821.html
>
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> Reviewed-by: David Hildenbrand <david@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Thanks Phil.
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
prev parent reply other threads:[~2021-09-03 16:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 16:06 [PATCH v6 0/2] memory: Have 'info mtree' remove duplicated Address Space information Philippe Mathieu-Daudé
2021-09-03 16:06 ` [PATCH v6 1/2] memory: Split mtree_info() as mtree_info_flatview() + mtree_info_as() Philippe Mathieu-Daudé
2021-09-03 16:06 ` [PATCH v6 2/2] memory: Have 'info mtree' remove duplicated Address Space information Philippe Mathieu-Daudé
2021-09-03 16:39 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTJP34IFfGAJ4oDp@t490s \
--to=peterx@redhat.com \
--cc=david@redhat.com \
--cc=kraxel@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).