From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47352C433F5 for ; Mon, 6 Sep 2021 14:33:45 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F0DC160EE6 for ; Mon, 6 Sep 2021 14:33:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F0DC160EE6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:46094 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNFgu-0001DL-27 for qemu-devel@archiver.kernel.org; Mon, 06 Sep 2021 10:33:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46870) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNFfz-0008S0-87 for qemu-devel@nongnu.org; Mon, 06 Sep 2021 10:32:47 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:48227) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNFfo-0001DR-5j for qemu-devel@nongnu.org; Mon, 06 Sep 2021 10:32:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630938754; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ivwICj42Q5qHD19RqJMvK9Wkk8/QHD+z5oH+qK8H9SY=; b=RusNSaTXap/StUpTltLG3CSjLeo9WnchthsKQgu9pZCxU77pl0XzcsZjIZNxCArms1BzRk JmVM/Inn2qsUf/djZop3Mv1y1RK1QtXy974XJqYqM2n7DUNZ4b1d3cIae284sSZeW0PjJ0 oWsYyq20wxGSvxHJglVEaUmUZaK71T4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-411-G9OYyArHP7mjgsxOcoQ3qg-1; Mon, 06 Sep 2021 10:32:32 -0400 X-MC-Unique: G9OYyArHP7mjgsxOcoQ3qg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4A36B100E417; Mon, 6 Sep 2021 14:32:26 +0000 (UTC) Received: from localhost (unknown [10.39.194.203]) by smtp.corp.redhat.com (Postfix) with ESMTP id E9F7710074E1; Mon, 6 Sep 2021 14:32:25 +0000 (UTC) Date: Mon, 6 Sep 2021 15:32:24 +0100 From: Stefan Hajnoczi To: Emanuele Giuseppe Esposito Subject: Re: [PATCH v2] include/block.h: remove outdated comment Message-ID: References: <20210903113800.59970-1-eesposit@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210903113800.59970-1-eesposit@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="YnnhAFw0L9qYidlb" Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.391, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Hanna Reitz , qemu-devel@nongnu.org, qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --YnnhAFw0L9qYidlb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 03, 2021 at 01:38:00PM +0200, Emanuele Giuseppe Esposito wrote: > There are a couple of errors in bdrv_drained_begin header comment: > - block_job_pause does not exist anymore, it has been replaced > with job_pause in b15de82867 > - job_pause is automatically invoked as a .drained_begin callback > (child_job_drained_begin) by the child_job BdrvChildClass struct > in blockjob.c. So no additional pause should be required. >=20 > Signed-off-by: Emanuele Giuseppe Esposito > --- > v2: > + add "block jobs" to the external request sources >=20 > include/block/block.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Stefan Hajnoczi --YnnhAFw0L9qYidlb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmE2JngACgkQnKSrs4Gr c8ilwgf/ZKxerZkw9SJj2pAf9z6ET9cIhqM4X2ZoUPoiPVT/bVbcHXO9E1veOibY k46CEHGTE21CuG5LatkDx7gvw8ffGr+4+pNXhvTE2MnKV5lliu34l0nJifVh7epK uM/NDW17pcIJM/7DmI2mjYuyRMlPq67pRE5jNUVlKndC+hl5Z5pfxcHOuzz1HvZd lGLCiER66AGYRXnQDcpzECN0DrceOXYryoeSr4zY/K9LK5sr8Og/Pp3pd3eACAsh J5mPJdQU5TfB6RZ/fAyKmj8YJ/nsYz0n6v5eKrTMDNR7x7Fr9c3+mLsVi8yPxTTK fcEjQT6FzaguQXy4F9EQP34a1mxf6Q== =yOv8 -----END PGP SIGNATURE----- --YnnhAFw0L9qYidlb--