From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EDDBC433EF for ; Wed, 8 Sep 2021 11:05:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA05860ED8 for ; Wed, 8 Sep 2021 11:05:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BA05860ED8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:34520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNvOu-0004WK-0j for qemu-devel@archiver.kernel.org; Wed, 08 Sep 2021 07:05:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51510) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNvM3-0002aF-DV for qemu-devel@nongnu.org; Wed, 08 Sep 2021 07:02:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:30798) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNvM1-0000Ge-J9 for qemu-devel@nongnu.org; Wed, 08 Sep 2021 07:02:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631098976; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=h05bdLJ8ik/TJC814xdFnl+X/NavX7mRRXq20qWmCpM=; b=M3Tzl36/4GL5gRuPVeA+Ez6scd1WuPvhNiHsPYjvGwX0IsekIIGxpriLKynv93Oh4n1h5Y tPBIfQId0iJZny9KRiHzz0nZt+ZHtpa92WnyLSXHzA2TvfCXoYy+RWBE2R10bwzbQEmW/i 19k1lyYJ25r+v4LGOWAALPLNUejet1Q= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-31-_f9IYsTfMkWjD4IoID4YtQ-1; Wed, 08 Sep 2021 07:02:55 -0400 X-MC-Unique: _f9IYsTfMkWjD4IoID4YtQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5C47C9126D for ; Wed, 8 Sep 2021 11:02:54 +0000 (UTC) Received: from redhat.com (unknown [10.39.192.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 15FD1196E2; Wed, 8 Sep 2021 11:02:52 +0000 (UTC) Date: Wed, 8 Sep 2021 12:02:50 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH 5/5] monitor: rewrite 'info registers' in terms of 'x-query-registers' Message-ID: References: <20210908103711.683940-1-berrange@redhat.com> <20210908103711.683940-6-berrange@redhat.com> <5634ab12-23b4-d2dd-fe7a-3a595ddc9e32@redhat.com> MIME-Version: 1.0 In-Reply-To: <5634ab12-23b4-d2dd-fe7a-3a595ddc9e32@redhat.com> User-Agent: Mutt/2.0.7 (2021-05-04) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.391, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Markus Armbruster , Eric Blake , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, Sep 08, 2021 at 01:01:21PM +0200, Philippe Mathieu-Daudé wrote: > On 9/8/21 12:37 PM, Daniel P. Berrangé wrote: > > Now that we have a QMP command 'x-query-registers', the HMP counterpart > > 'info registers' can be refactored to call the former. > > > > Signed-off-by: Daniel P. Berrangé > > --- > > monitor/misc.c | 25 ++++++++++++++++--------- > > 1 file changed, 16 insertions(+), 9 deletions(-) > > > > diff --git a/monitor/misc.c b/monitor/misc.c > > index ffe7966870..f0b94c3084 100644 > > --- a/monitor/misc.c > > +++ b/monitor/misc.c > > @@ -67,6 +67,7 @@ > > #include "block/block-hmp-cmds.h" > > #include "qapi/qapi-commands-char.h" > > #include "qapi/qapi-commands-control.h" > > +#include "qapi/qapi-commands-machine.h" > > #include "qapi/qapi-commands-migration.h" > > #include "qapi/qapi-commands-misc.h" > > #include "qapi/qapi-commands-qom.h" > > @@ -301,23 +302,29 @@ int monitor_get_cpu_index(Monitor *mon) > > static void hmp_info_registers(Monitor *mon, const QDict *qdict) > > { > > bool all_cpus = qdict_get_try_bool(qdict, "cpustate_all", false); > > - CPUState *cs; > > + bool has_cpu = !all_cpus; > > + int64_t cpu = 0; > > + Error *local_err = NULL; > > + g_autoptr(RegisterInfo) info = NULL; > > > > - if (all_cpus) { > > - CPU_FOREACH(cs) { > > - monitor_printf(mon, "\nCPU#%d\n", cs->cpu_index); > > - cpu_dump_state(cs, NULL, CPU_DUMP_FPU); > > And once all targets are converted we can remove cpu_dump_state(). Yes, if we take approach in this series, then there would be another 20-ish patches inserted before this one, to convert all the other targets, and eliminate the cpu_dump_state method / callback. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|