From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65E8DC433F5 for ; Wed, 8 Sep 2021 12:21:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F3356113D for ; Wed, 8 Sep 2021 12:21:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0F3356113D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:51020 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNwaC-0000aB-SP for qemu-devel@archiver.kernel.org; Wed, 08 Sep 2021 08:21:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39682) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNwWl-0005uo-JG for qemu-devel@nongnu.org; Wed, 08 Sep 2021 08:18:07 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:31672) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNwWk-00049B-4S for qemu-devel@nongnu.org; Wed, 08 Sep 2021 08:18:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631103483; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iuKTHBPWuaVoURsAPRjAi/vjChAOyU9ZXWl+vHq0dYc=; b=K32b9VqxHDSUTojiCbrfHohMajFFvR+jmfO+kc70pT8U/JsRiSOFGH5yTZbY6ra5W9MSFQ VPTATYobTz/OSH8JD/VCgaP2OSJpCdiOiihcBWoapIl+R7UEHY5zeFQyM4w4yQM0BGuNbX nlehVvui59/TAIUv9qkjQ2WiShEMe8Q= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-123-xajgtGtlOdC_rMkZjlg_sw-1; Wed, 08 Sep 2021 08:18:02 -0400 X-MC-Unique: xajgtGtlOdC_rMkZjlg_sw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8D36F8464D4 for ; Wed, 8 Sep 2021 12:18:01 +0000 (UTC) Received: from fedora (unknown [10.43.2.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 47F631001281; Wed, 8 Sep 2021 12:18:00 +0000 (UTC) Date: Wed, 8 Sep 2021 14:17:57 +0200 From: =?iso-8859-1?B?SuFu?= Tomko To: Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= Subject: Re: [PATCH 3/5] target/i386: convert to use format_state instead of dump_state Message-ID: References: <20210908103711.683940-1-berrange@redhat.com> <20210908103711.683940-4-berrange@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210908103711.683940-4-berrange@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jtomko@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uQaMm0z9q0BIvDfS" Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=jtomko@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.393, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Markus Armbruster , Eric Blake , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --uQaMm0z9q0BIvDfS Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On a Wednesday in 2021, Daniel P. Berrang=E9 wrote: >Signed-off-by: Daniel P. Berrang=E9 >--- > target/i386/cpu-dump.c | 325 ++++++++++++++++++++++------------------- > target/i386/cpu.c | 2 +- > target/i386/cpu.h | 2 +- > 3 files changed, 174 insertions(+), 155 deletions(-) > >diff --git a/target/i386/cpu-dump.c b/target/i386/cpu-dump.c >index 02b635a52c..8e19485a20 100644 >--- a/target/i386/cpu-dump.c >+++ b/target/i386/cpu-dump.c [...] >@@ -355,107 +359,116 @@ void x86_cpu_dump_state(CPUState *cs, FILE *f, int= flags) [...] > { >- qemu_fprintf(f, "GDT=3D %08x %08x\n", >- (uint32_t)env->gdt.base, env->gdt.limit); >- qemu_fprintf(f, "IDT=3D %08x %08x\n", >- (uint32_t)env->idt.base, env->idt.limit); >- qemu_fprintf(f, "CR0=3D%08x CR2=3D%08x CR3=3D%08x CR4=3D%08x\n", >- (uint32_t)env->cr[0], >- (uint32_t)env->cr[2], >- (uint32_t)env->cr[3], >- (uint32_t)env->cr[4]); >+ g_string_append_printf(buf, "GDT=3D %08x %08x\n", >+ (uint32_t)env->gdt.base, env->gdt.limit); >+ g_string_append_printf(buf, "IDT=3D %08x %08x\n", >+ (uint32_t)env->idt.base, env->idt.limit); >+ g_string_append_printf(buf, "CR0=3D%08x CR2=3D%08x CR3=3D%08x CR4= =3D%08x\n", >+ (uint32_t)env->cr[0], >+ (uint32_t)env->cr[2], >+ (uint32_t)env->cr[3], >+ (uint32_t)env->cr[4]); > for(i =3D 0; i < 4; i++) { >- qemu_fprintf(f, "DR%d=3D" TARGET_FMT_lx " ", i, env->dr[i]); >+ g_string_append_printf(buf, "DR%d=3D" TARGET_FMT_lx >+ " ", i, env->dr[i]); The formatting string can comfortably fit on the first line here. Jano > } >- qemu_fprintf(f, "\nDR6=3D" TARGET_FMT_lx " DR7=3D" TARGET_FMT_lx = "\n", >- env->dr[6], env->dr[7]); >+ g_string_append_printf(buf, "\nDR6=3D" TARGET_FMT_lx >+ " DR7=3D" TARGET_FMT_lx "\n", >+ env->dr[6], env->dr[7]); --uQaMm0z9q0BIvDfS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE7DTm0WabvfIr7YZ4Ak1z5KIMl5QFAmE4qfAACgkQAk1z5KIM l5Rflgf/aqN5UDP7XglN8T9MdMHZY9C/xg4bQEFXTSR9+CPI7rEil6KJtnQMWr3Y dTGKhI35yYI6IX9ZNkhQDvUti2LBM5str0tWFfhdBKODiC52JkSkycmQHTWHBHiW oUg8UTG0OxKfPizovUtXaQGU056RlXGxjFOtZcZm+mxRmgQwVNkQ86cw9qEg+t6l H+TGfoaYXmXaFTtX02ROAwiMTBBUzsglFBneUY7XhCTOPpvfdcdnc6vOjpWooJgL kQ+fASh8pXJvQyDpp0F/yzhoNKwP8aKCuc1CYpMSOcxDbicyKKSGzkvU1GJq3Clq SmK+vRJVX50a3EVZ4bX3yIRk9SMr7A== =k1NI -----END PGP SIGNATURE----- --uQaMm0z9q0BIvDfS--