From: Stefan Hajnoczi <stefanha@redhat.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH 2/2] iothread: use IOThreadParamInfo in iothread_[set|get]_param()
Date: Wed, 8 Sep 2021 15:42:15 +0100 [thread overview]
Message-ID: <YTjLxwRcwfOj8Pv1@stefanha-x1.localdomain> (raw)
In-Reply-To: <20210727145936.147032-3-sgarzare@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 669 bytes --]
On Tue, Jul 27, 2021 at 04:59:36PM +0200, Stefano Garzarella wrote:
> Commit 0445409d74 ("iothread: generalize
> iothread_set_param/iothread_get_param") moved common code to set and
> get IOThread parameters in two new functions.
>
> These functions are called inside callbacks, so we don't need to use an
> opaque pointer. Let's replace `void *opaque` parameter with
> `IOThreadParamInfo *info`.
>
> Suggested-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> ---
> iothread.c | 18 ++++++++++--------
> 1 file changed, 10 insertions(+), 8 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-09-08 14:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 14:59 [PATCH 0/2] iothread: cleanup after adding a new parameter to IOThread Stefano Garzarella
2021-07-27 14:59 ` [PATCH 1/2] iothread: rename PollParamInfo to IOThreadParamInfo Stefano Garzarella
2021-09-08 14:40 ` Stefan Hajnoczi
2021-07-27 14:59 ` [PATCH 2/2] iothread: use IOThreadParamInfo in iothread_[set|get]_param() Stefano Garzarella
2021-09-08 14:42 ` Stefan Hajnoczi [this message]
2021-09-06 13:46 ` [PATCH 0/2] iothread: cleanup after adding a new parameter to IOThread Stefano Garzarella
2021-09-06 14:20 ` Philippe Mathieu-Daudé
2021-09-08 15:04 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTjLxwRcwfOj8Pv1@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).