From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E4A0C433EF for ; Fri, 10 Sep 2021 13:53:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BFAB1611C3 for ; Fri, 10 Sep 2021 13:53:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BFAB1611C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:50770 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mOgyE-0002x2-Or for qemu-devel@archiver.kernel.org; Fri, 10 Sep 2021 09:53:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57806) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mOgxX-0002H3-Er for qemu-devel@nongnu.org; Fri, 10 Sep 2021 09:52:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:21671) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mOgxV-0005vT-NH for qemu-devel@nongnu.org; Fri, 10 Sep 2021 09:52:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631281968; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mk/NVZRCNZgHeikrJ4wyDAN4nTp2njOGEWH+JseOaiw=; b=Kv7TgcrFgnxT/d55JluSxnnFp2M4q5HQ4WxE5HYkBO4CqK8XP7Onnh0vDJrZwDyGMFQCM1 Ks5BLz14WPA6RmYhnauaIA8kN5DqELiTmZAIcFU9j5xeWWKag3cqSJ9M/xy+vbw42rra7N /wXQqdmhNXv1g5zTuUSiry+ZPxzgw9I= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-79-YG3yo-FUOPCVTF_Ak4skAg-1; Fri, 10 Sep 2021 09:52:47 -0400 X-MC-Unique: YG3yo-FUOPCVTF_Ak4skAg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A8C90801596; Fri, 10 Sep 2021 13:52:46 +0000 (UTC) Received: from redhat.com (unknown [10.39.194.181]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4E99919D9F; Fri, 10 Sep 2021 13:52:45 +0000 (UTC) Date: Fri, 10 Sep 2021 14:52:42 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Markus Armbruster Subject: Re: [PATCH 1/5] docs/devel: document expectations for QAPI data modelling for QMP Message-ID: References: <20210908103711.683940-1-berrange@redhat.com> <20210908103711.683940-2-berrange@redhat.com> <87tuium6u7.fsf@dusky.pond.sub.org> <87sfyca6jc.fsf@dusky.pond.sub.org> MIME-Version: 1.0 In-Reply-To: <87sfyca6jc.fsf@dusky.pond.sub.org> User-Agent: Mutt/2.0.7 (2021-05-04) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.392, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Eduardo Habkost , Eric Blake , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Sep 10, 2021 at 03:45:11PM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Thu, Sep 09, 2021 at 11:33:20AM +0200, Markus Armbruster wrote: > > [...] > > >> There are many existing long lines in this file, so I'm not flagging > >> yours, except for this one, because it increases the maximum. > > > > This line is at exactly 80 characters so checkstyle is happy with it. > > We don't have any requirement for a differenet line limit for docs > > afair ? > > We don't. I'm asking for a favour. > > Humans tend to have trouble following long lines with our eyes (I sure > do). Typographic manuals suggest to limit columns to roughly 60 > characters for exactly that reason[1]. > > 70 is a reasonable compromise between legibility and "writability". For > code, we use 80-90, because there the actual width should still be fine > due to indentation. > > checkpatch.pl doesn't differentiate betwen code and prose. > > This file is already hard to read for me. Please consider not making it > harder. Ok, no worries, I just didn't understand the rationale. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|