From: David Gibson <david@gibson.dropbear.id.au>
To: Luis Pires <luis.pires@eldorado.org.br>
Cc: richard.henderson@linaro.org, qemu-ppc@nongnu.org,
qemu-devel@nongnu.org, groug@kaod.org
Subject: Re: [PATCH v3 00/22] target/ppc: DFP instructions using decodetree
Date: Wed, 15 Sep 2021 13:15:13 +1000 [thread overview]
Message-ID: <YUFlQcHovtytx90O@yekko> (raw)
In-Reply-To: <20210910112624.72748-1-luis.pires@eldorado.org.br>
[-- Attachment #1: Type: text/plain, Size: 2330 bytes --]
On Fri, Sep 10, 2021 at 08:26:02AM -0300, Luis Pires wrote:
> This series moves all existing DFP instructions to decodetree and
> implements the 2 new instructions (dcffixqq and dctfixqq) from
> Power ISA 3.1.
>
> In order to implement dcffixqq, divu128/divs128 were modified to
> support 128-bit quotients (previously, they were limited to 64-bit
> quotients), along with adjustments being made to their existing callers.
> libdecnumber was also expanded to allow creating decimal numbers from
> 128-bit integers.
>
> Similarly, for dctfixqq, mulu128 (host-utils) and decNumberIntegralToInt128
> (libdecnumber) were introduced to support 128-bit integers.
>
> The remaining patches of this series move all of the already existing
> DFP instructions to decodetree, and end up removing dfp-ops.c.inc, which
> is no longer needed.
>
> NOTE 1: The previous, non-decodetree code, was updating ctx->nip for all the
> DFP instructions. I've removed that, but it would be great if someone could
> confirm that updating nip really wasn't necessary.
>
> NOTE 2: Some arithmetic function support for 128-bit integers was added,
> for now, still using 64-bit pairs. In the near future, I think we should
> modify all of them to use Int128 (and introduce UInt128). But I'll send
> out an RFC to discuss how to do that in another patch series.
>
> NOTE 3: The helper names are in uppercase, to match the instruction
> names and to simplify the macros that define trans* functions.
> Previously, this wasn't the case, as we were using lowercase instruction
> names in the pre-decodetree code. Another standalone patch will be sent
> later on, changing to uppercase the other new (decodetree) helpers whose
> names are directly related to instruction names, eventually making PPC
> helper names consistent.
>
> Based-on: 20210823150235.35759-1-luis.pires@eldorado.org.br
> (target/ppc: fix setting of CR flags in bcdcfsq)
> This series assumes bcdcfsq's fix is already in.
I've applied 1..4 to ppc-for-6.2, since those have acks. Waiting on
reviews (probably from Richard) before applying the rest.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-09-15 3:24 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 11:26 [PATCH v3 00/22] target/ppc: DFP instructions using decodetree Luis Pires
2021-09-10 11:26 ` [PATCH v3 01/22] host-utils: Fix overflow detection in divu128() Luis Pires
2021-09-10 11:26 ` [PATCH v3 02/22] host-utils: fix missing zero-extension in divs128 Luis Pires
2021-10-21 20:02 ` Richard Henderson
2021-09-10 11:26 ` [PATCH v3 03/22] host-utils: introduce uabs64() Luis Pires
2021-10-21 20:04 ` Richard Henderson
2021-10-21 22:34 ` Eduardo Habkost
2021-10-21 23:23 ` Richard Henderson
2021-09-10 11:26 ` [PATCH v3 04/22] i386/kvm: Replace abs64() with uabs64() from host-utils Luis Pires
2021-09-10 11:26 ` [PATCH v3 05/22] host-utils: move checks out of divu128/divs128 Luis Pires
2021-10-21 20:11 ` Richard Henderson
2021-09-10 11:26 ` [PATCH v3 06/22] host-utils: move udiv_qrnnd() to host-utils Luis Pires
2021-10-21 20:14 ` Richard Henderson
2021-09-10 11:26 ` [PATCH v3 07/22] host-utils: add 128-bit quotient support to divu128/divs128 Luis Pires
2021-10-21 21:14 ` Richard Henderson
2021-10-25 18:51 ` Luis Fernando Fujita Pires
2021-09-10 11:26 ` [PATCH v3 08/22] host-utils: add unit tests for divu128/divs128 Luis Pires
2021-10-21 21:16 ` Richard Henderson
2021-09-10 11:26 ` [PATCH v3 09/22] libdecnumber: introduce decNumberFrom[U]Int128 Luis Pires
2021-09-10 11:26 ` [PATCH v3 10/22] target/ppc: Move REQUIRE_ALTIVEC/VECTOR to translate.c Luis Pires
2021-09-10 11:26 ` [PATCH v3 11/22] target/ppc: Introduce REQUIRE_FPU Luis Pires
2021-09-10 11:26 ` [PATCH v3 12/22] target/ppc: Implement DCFFIXQQ Luis Pires
2021-10-21 21:27 ` Richard Henderson
2021-09-10 11:26 ` [PATCH v3 13/22] host-utils: Introduce mulu128 Luis Pires
2021-09-10 11:26 ` [PATCH v3 14/22] libdecnumber: Introduce decNumberIntegralToInt128 Luis Pires
2021-09-10 11:26 ` [PATCH v3 15/22] target/ppc: Implement DCTFIXQQ Luis Pires
2021-10-21 21:39 ` Richard Henderson
2021-10-25 18:51 ` Luis Fernando Fujita Pires
2021-09-10 11:26 ` [PATCH v3 16/22] target/ppc: Move dtstdc[q]/dtstdg[q] to decodetree Luis Pires
2021-10-21 21:58 ` Richard Henderson
2021-10-25 18:52 ` Luis Fernando Fujita Pires
2021-09-10 11:26 ` [PATCH v3 17/22] target/ppc: Move d{add, sub, mul, div, iex}[q] " Luis Pires
2021-10-21 22:05 ` [PATCH v3 17/22] target/ppc: Move d{add,sub,mul,div,iex}[q] " Richard Henderson
2021-09-10 11:26 ` [PATCH v3 18/22] target/ppc: Move dcmp{u, o}[q], dts{tex, tsf, tsfi}[q] " Luis Pires
2021-10-21 22:15 ` [PATCH v3 18/22] target/ppc: Move dcmp{u,o}[q],dts{tex,tsf,tsfi}[q] " Richard Henderson
2021-09-10 11:26 ` [PATCH v3 19/22] target/ppc: Move dquai[q], drint{x, n}[q] " Luis Pires
2021-10-21 22:22 ` [PATCH v3 19/22] target/ppc: Move dquai[q], drint{x,n}[q] " Richard Henderson
2021-09-10 11:26 ` [PATCH v3 20/22] target/ppc: Move dqua[q], drrnd[q] " Luis Pires
2021-10-21 22:27 ` Richard Henderson
2021-09-10 11:26 ` [PATCH v3 21/22] target/ppc: Move dct{dp, qpq}, dr{sp, dpq}, dc{f, t}fix[q], dxex[q] " Luis Pires
2021-10-21 22:35 ` [PATCH v3 21/22] target/ppc: Move dct{dp,qpq},dr{sp,dpq},dc{f,t}fix[q],dxex[q] " Richard Henderson
2021-09-10 11:26 ` [PATCH v3 22/22] target/ppc: Move ddedpd[q], denbcd[q], dscli[q], dscri[q] " Luis Pires
2021-10-21 23:21 ` [PATCH v3 22/22] target/ppc: Move ddedpd[q],denbcd[q],dscli[q],dscri[q] " Richard Henderson
2021-09-15 3:15 ` David Gibson [this message]
2021-09-20 18:50 ` [PATCH v3 00/22] target/ppc: DFP instructions using decodetree Luis Fernando Fujita Pires
2021-10-14 17:02 ` Luis Fernando Fujita Pires
2021-10-15 3:15 ` david
2021-10-15 11:52 ` Luis Fernando Fujita Pires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUFlQcHovtytx90O@yekko \
--to=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=luis.pires@eldorado.org.br \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).