From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 099BAC433EF for ; Wed, 15 Sep 2021 08:31:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 71CB460ED8 for ; Wed, 15 Sep 2021 08:31:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 71CB460ED8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:35342 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQQJo-0001va-DD for qemu-devel@archiver.kernel.org; Wed, 15 Sep 2021 04:31:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41070) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQQIG-0001AZ-Vo for qemu-devel@nongnu.org; Wed, 15 Sep 2021 04:29:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:56861) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQQID-000081-GT for qemu-devel@nongnu.org; Wed, 15 Sep 2021 04:29:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631694559; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=X6E0i7t5UUWpWanN9IOWnLPLVZdRlLY3ZQZl/PmTlLs=; b=OXgPRgqDbu4PokbDhb3avITCjOpMxAZRDO/27IUDTol/UaxRV3TOFH27CbtQuPEDS0IZ6r 9IlBM9nlofcxsY1d+U2/Zz70BG7Ao5w2bcyBAl4sbxkVkZgtVhH05vRfv0LD5bBbt5wfem pmH4CSroo30VG/80CCbVHt704fcWWMo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-17-B5ygwKb3PE6vnWtCMHhPqw-1; Wed, 15 Sep 2021 04:29:13 -0400 X-MC-Unique: B5ygwKb3PE6vnWtCMHhPqw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 49DCF18D6A2A; Wed, 15 Sep 2021 08:29:12 +0000 (UTC) Received: from redhat.com (unknown [10.39.194.233]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9C75C18B5E; Wed, 15 Sep 2021 08:29:10 +0000 (UTC) Date: Wed, 15 Sep 2021 09:29:08 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Peter Maydell Subject: Re: [PATCH] gitlab-ci: Make more custom runner jobs manual, and don't allow failure Message-ID: References: <20210913101948.12600-1-peter.maydell@linaro.org> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.0.7 (2021-05-04) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.398, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Thomas Huth , QEMU Developers , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Willian Rampazzo , Cleber Rosa , Alex =?utf-8?Q?Benn=C3=A9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Sep 14, 2021 at 08:17:19PM +0100, Peter Maydell wrote: > On Mon, 13 Sept 2021 at 11:19, Peter Maydell wrote: > > > > Currently we define a lot of jobs for our custom runners: > > for both aarch64 and s390x we have > > - all-linux-static > > - all > > - alldbg > > - clang (manual) > > - tci > > - notcg (manual) > > > > This is overkill. The main reason to run on these hosts is to get > > coverage for the host architecture; we can leave the handling of > > differences like debug vs non-debug to the x86 CI jobs. > > > > The jobs are also generally running OK; they occasionally fail due to > > timeouts, which is likely because we're overloading the machine by > > asking it to run 4 CI jobs at once plus the ad-hoc CI. > > > > Remove the 'allow_failure' tag from all these jobs, and switch the > > s390x-alldbg, aarch64-all, s390x-tci and aarch64-tci jobs to manual. > > This will let us make the switch for s390x and aarch64 hosts from > > the ad-hoc CI to gitlab. > > > > Signed-off-by: Peter Maydell > > It looks like this change has resulted in pipelines ending > up in a "blocked" state: > > https://gitlab.com/qemu-project/qemu/-/pipelines > > I'm not sure why this is -- is it perhaps because there were > other jobs that depended on the now-manual-only jobs ? > Can somebody suggest a fix ? Urgh, my bad, I completely forget this behaviour when reviewing. When we only have when: manual then the job has to be manually started, and it still contributes to pipeline status, so it /must/ triggered manually. If we want it to be manually started and not contribute to the pipeline status we need: rules: ... when: manual allow_failure: true Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|