From: David Gibson <david@gibson.dropbear.id.au>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Maarten Koning" <maarten.koning@windriver.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Greg Kurz" <groug@kaod.org>,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
"Cédric Le Goater" <clg@kaod.org>,
"Bin Meng" <bmeng.cn@gmail.com>
Subject: Re: [RESEND PATCH 1/3] hw/intc: openpic: Correct the reset value of IPIDR for FSL chipset
Date: Tue, 21 Sep 2021 19:31:46 +1000 [thread overview]
Message-ID: <YUmmgie0uNg3ESZr@yekko> (raw)
In-Reply-To: <c329c9a4-0662-4a4f-70fc-b3eda07cb149@amsat.org>
[-- Attachment #1: Type: text/plain, Size: 1929 bytes --]
On Tue, Sep 21, 2021 at 10:13:36AM +0200, Philippe Mathieu-Daudé wrote:
> On 9/21/21 05:25, David Gibson wrote:
> > On Sat, Sep 18, 2021 at 11:26:51AM +0800, Bin Meng wrote:
> > > The reset value of IPIDR should be zero for Freescale chipset, per
> > > the following 2 manuals I checked:
> > >
> > > - P2020RM (https://www.nxp.com/webapp/Download?colCode=P2020RM)
> > > - P4080RM (https://www.nxp.com/webapp/Download?colCode=P4080RM)
> > >
> > > Currently it is set to 1, which leaves the IPI enabled on core 0
> > > after power-on reset. Such may cause unexpected interrupt to be
> > > delivered to core 0 if the IPI is triggered from core 0 to other
> > > cores later.
> > >
> > > Fixes: ffd5e9fe0276 ("openpic: Reset IRQ source private members")
> > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/584
> > > Signed-off-by: Bin Meng <bin.meng@windriver.com>
> >
> > Since these patches are very simple and look sensible, I've applied
> > them to ppc-for-6.2.
> >
> > However, you should note that Greg and I are both moving into other
> > areas and don't have much capacity for ppc maintainership any more.
> > Therefore I'll shortly be sending some MAINTAINERS updates moving
> > openpic (amongst other things) to "Orphan" status.
>
> I'm not trying to force Bin to become (yet) another maintainer,
> but from his previous contributions, he demonstrated a very good
> knowledge of embedded PowerPC ISA & chipsets, his patches have good
> quality and description, and he is consistent over time in his
> contributions. So if he is interested, I'd vouch for him as a
> maintainer for embedded ppc. Now up to him, his time and/or employer
> :)
Ok, works for me if he's interested.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-09-21 9:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-18 3:26 [RESEND PATCH 1/3] hw/intc: openpic: Correct the reset value of IPIDR for FSL chipset Bin Meng
2021-09-18 3:26 ` [RESEND PATCH 2/3] hw/intc: openpic: Drop Raven related codes Bin Meng
2021-09-18 3:26 ` [RESEND PATCH 3/3] hw/intc: openpic: Clean up the styles Bin Meng
2021-09-21 3:25 ` [RESEND PATCH 1/3] hw/intc: openpic: Correct the reset value of IPIDR for FSL chipset David Gibson
2021-09-21 8:13 ` Philippe Mathieu-Daudé
2021-09-21 9:31 ` David Gibson [this message]
2021-09-23 5:33 ` Bin Meng
2021-09-27 4:30 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUmmgie0uNg3ESZr@yekko \
--to=david@gibson.dropbear.id.au \
--cc=bmeng.cn@gmail.com \
--cc=clg@kaod.org \
--cc=f4bug@amsat.org \
--cc=groug@kaod.org \
--cc=maarten.koning@windriver.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).