From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Andrew Jones" <drjones@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
"Leonardo Bras Soares Passos" <lsoaresp@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v2 0/3] dump-guest-memory: Add blocker for migration
Date: Wed, 22 Sep 2021 10:33:31 -0400 [thread overview]
Message-ID: <YUs+uxw03rpMeZ46@t490s> (raw)
In-Reply-To: <20210826185813.248441-1-peterx@redhat.com>
On Thu, Aug 26, 2021 at 02:58:10PM -0400, Peter Xu wrote:
> v2:
> - One more patch: "migration: Make migration blocker work for snapshots too"
> - Move register of migration blocker to be before dump_init [Marc-Andre]
> - Collected r-bs
>
> Both dump-guest-memory and live migration have vm state cached internally.
> Allowing them to happen together means the vm state can be messed up. Simply
> block live migration for dump-guest-memory.
>
> One trivial thing to mention is we should still allow dump-guest-memory even if
> -only-migratable is specified, because that flag should majorly be used to
> guarantee not adding devices that will block migration by accident. Dump guest
> memory is not like that - it'll only block for the seconds when it's dumping.
Ping?
--
Peter Xu
prev parent reply other threads:[~2021-09-22 14:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 18:58 [PATCH v2 0/3] dump-guest-memory: Add blocker for migration Peter Xu
2021-08-26 18:58 ` [PATCH v2 1/3] migration: Make migration blocker work for snapshots too Peter Xu
2021-09-22 15:05 ` Marc-André Lureau
2021-08-26 18:58 ` [PATCH v2 2/3] migration: Add migrate_add_blocker_internal() Peter Xu
2021-08-26 18:58 ` [PATCH v2 3/3] dump-guest-memory: Block live migration Peter Xu
2021-08-27 7:44 ` Marc-André Lureau
2021-08-27 7:51 ` Marc-André Lureau
2021-08-27 14:50 ` Peter Xu
2021-09-22 15:18 ` Marc-André Lureau
2021-09-22 16:00 ` Peter Xu
2021-09-22 14:33 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUs+uxw03rpMeZ46@t490s \
--to=peterx@redhat.com \
--cc=armbru@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=dgilbert@redhat.com \
--cc=drjones@redhat.com \
--cc=lsoaresp@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).