From: David Gibson <david@gibson.dropbear.id.au>
To: "Cédric Le Goater" <clg@kaod.org>
Cc: qemu-ppc@nongnu.org, Greg Kurz <groug@kaod.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH] spapr/xive: Use xive_esb_rw() to trigger interrupts
Date: Thu, 7 Oct 2021 11:47:22 +1100 [thread overview]
Message-ID: <YV5Dmk3j1OLCBFxa@yekko> (raw)
In-Reply-To: <20211006210546.641102-1-clg@kaod.org>
[-- Attachment #1: Type: text/plain, Size: 1155 bytes --]
On Wed, Oct 06, 2021 at 11:05:46PM +0200, Cédric Le Goater wrote:
> xive_esb_rw() is the common routine used for memory accesses on ESB
> page. Use it for triggers also.
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
Applied to ppc-fot-6.2, thanks.
> ---
> hw/intc/spapr_xive_kvm.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hw/intc/spapr_xive_kvm.c b/hw/intc/spapr_xive_kvm.c
> index 630a719d578e..2f79950a644e 100644
> --- a/hw/intc/spapr_xive_kvm.c
> +++ b/hw/intc/spapr_xive_kvm.c
> @@ -318,9 +318,7 @@ static uint8_t xive_esb_read(XiveSource *xsrc, int srcno, uint32_t offset)
>
> static void kvmppc_xive_esb_trigger(XiveSource *xsrc, int srcno)
> {
> - uint64_t *addr = xsrc->esb_mmap + xive_source_esb_page(xsrc, srcno);
> -
> - *addr = 0x0;
> + xive_esb_rw(xsrc, srcno, 0, 0, true);
> }
>
> uint64_t kvmppc_xive_esb_rw(XiveSource *xsrc, int srcno, uint32_t offset,
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-10-07 0:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 21:05 [PATCH] spapr/xive: Use xive_esb_rw() to trigger interrupts Cédric Le Goater
2021-10-07 0:47 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YV5Dmk3j1OLCBFxa@yekko \
--to=david@gibson.dropbear.id.au \
--cc=clg@kaod.org \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).