From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDD29C433EF for ; Thu, 7 Oct 2021 08:47:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2716A61130 for ; Thu, 7 Oct 2021 08:47:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2716A61130 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:37206 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mYP40-00086j-7G for qemu-devel@archiver.kernel.org; Thu, 07 Oct 2021 04:47:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54008) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYP1k-0006cD-5Z for qemu-devel@nongnu.org; Thu, 07 Oct 2021 04:45:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:51315) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mYP1b-0005UG-OS for qemu-devel@nongnu.org; Thu, 07 Oct 2021 04:45:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633596309; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=U1fZMibab7DDnqtLyVLRoSzpGk8+tIH09T/jSzDJbig=; b=iJeRg/mvyCrseIS1IKqur2nU/PKSb23EA5sGxEweX2P9AuanJzYCO9wpd5pqvFsC9erfE0 HqZ9V0EZEXcjqfkFJMz4zzNYxuuQT83lQa+6XOpR87DrxoAzrC1+177NHnaDp9fxkENrnw cJmOOqkM8HPYO3LVFFqIbTdTaGS+RLM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-542-80jl98J9MnO6oh8IAzhEFA-1; Thu, 07 Oct 2021 04:44:44 -0400 X-MC-Unique: 80jl98J9MnO6oh8IAzhEFA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1D844101AFA8; Thu, 7 Oct 2021 08:44:43 +0000 (UTC) Received: from redhat.com (unknown [10.39.195.96]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 01C951F46B; Thu, 7 Oct 2021 08:43:29 +0000 (UTC) Date: Thu, 7 Oct 2021 09:43:27 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Eric Blake Subject: Re: [PATCH v7 3/8] qmp: add QMP command x-debug-query-virtio Message-ID: References: <1633452353-7169-1-git-send-email-jonah.palmer@oracle.com> <1633452353-7169-4-git-send-email-jonah.palmer@oracle.com> <20211005212421.yfn6jrciih22l5ce@redhat.com> MIME-Version: 1.0 In-Reply-To: <20211005212421.yfn6jrciih22l5ce@redhat.com> User-Agent: Mutt/2.0.7 (2021-05-04) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.05, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: fam@euphon.net, mst@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com, si-wei.liu@oracle.com, joao.m.martins@oracle.com, mreitz@redhat.com, qemu-block@nongnu.org, david@redhat.com, armbru@redhat.com, marcandre.lureau@redhat.com, Jonah Palmer , thuth@redhat.com, amit@kernel.org, michael.roth@amd.com, dgilbert@redhat.com, eric.auger@redhat.com, dmitrii.stepanov@cloud.ionos.com, stefanha@redhat.com, boris.ostrovsky@oracle.com, kwolf@redhat.com, laurent@vivier.eu, raphael.norwitz@nutanix.com, pbonzini@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Oct 05, 2021 at 04:24:21PM -0500, Eric Blake wrote: > On Tue, Oct 05, 2021 at 12:45:48PM -0400, Jonah Palmer wrote: > > From: Laurent Vivier > > > > This new command lists all the instances of VirtIODevice with > > their QOM paths and virtio type/name. > > > > Signed-off-by: Jonah Palmer > > --- > > hw/virtio/meson.build | 2 ++ > > hw/virtio/virtio-stub.c | 14 ++++++++++ > > hw/virtio/virtio.c | 27 +++++++++++++++++++ > > include/hw/virtio/virtio.h | 1 + > > qapi/meson.build | 1 + > > qapi/qapi-schema.json | 1 + > > qapi/virtio.json | 66 ++++++++++++++++++++++++++++++++++++++++++++++ > > tests/qtest/qmp-cmd-test.c | 1 + > > 8 files changed, 113 insertions(+) > > create mode 100644 hw/virtio/virtio-stub.c > > create mode 100644 qapi/virtio.json > > > > [Jonah: VirtioInfo member 'type' is now of type string and no longer > > relies on defining a QAPI list of virtio device type enumerations > > to match the VirtIODevice name with qapi_enum_parse().] > > Hmm; depending on how much information you want to cram in strings, we > may want to rebase this series on top of Dan's work to add the > HumanReadableText QAPI type: > https://lists.gnu.org/archive/html/qemu-devel/2021-09/msg07717.html The HumanReadableText type is only needed for commands that return entirely unstructured data, eg returns a HumanReadableText, or an array of HumanReadableText. The command here is returning semi-structured data, so I don't think it needs to depend on HumanReadableText. > > > +++ b/qapi/virtio.json > > @@ -0,0 +1,66 @@ > > +# -*- Mode: Python -*- > > +# vim: filetype=python > > +# > > + > > +## > > +# = Virtio devices > > +## > > + > > +## > > +# @VirtioInfo: > > +# > > +# Information about a given VirtIODevice > > +# > > +# @path: VirtIO device canonical QOM path. > > +# > > +# @type: VirtIO device name. > > +# > > +# Since: 6.2 > > +# > > +## > > +{ 'struct': 'VirtioInfo', > > + 'data': { > > + 'path': 'str', > > + 'type': 'str' > > + } > > +} > > + > > +## > > +# @x-debug-query-virtio: > > +# > > +# Return a list of all initalized VirtIO devices > > +# > > +# Returns: list of gathered @VirtioInfo devices > > +# > > +# Since: 6.2 > > +# > > +# Example: > > +# > > +# -> { "execute": "x-debug-query-virtio" } > > +# <- { "return": [ > > +# { > > +# "path": "/machine/peripheral-anon/device[4]/virtio-backend", > > +# "type": "virtio-input" > > +# }, > > +# { > > +# "path": "/machine/peripheral/crypto0/virtio-backend", > > +# "type": "virtio-crypto" > > +# }, > > +# { > > +# "path": "/machine/peripheral-anon/device[2]/virtio-backend", > > +# "type": "virtio-scsi" > > +# }, > > +# { > > +# "path": "/machine/peripheral-anon/device[1]/virtio-backend", > > +# "type": "virtio-net" > > +# }, > > +# { > > +# "path": "/machine/peripheral-anon/device[0]/virtio-backend", > > +# "type": "virtio-serial" > > +# } > > +# ] > > +# } > > +# > > +## > > + > > +{ 'command': 'x-debug-query-virtio', 'returns': ['VirtioInfo'] } > > But for now, it looks like 'str' is the correct type. > > > -- > Eric Blake, Principal Software Engineer > Red Hat, Inc. +1-919-301-3266 > Virtualization: qemu.org | libvirt.org > Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|