From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Brijesh Singh <brijesh.singh@amd.com>,
Eduardo Habkost <ehabkost@redhat.com>,
kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
Sergio Lopez <slp@redhat.com>,
James Bottomley <jejb@linux.ibm.com>,
qemu-devel@nongnu.org, Dov Murik <dovmurik@linux.ibm.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v4 14/23] target/i386/sev: Rename sev_i386.h -> sev.h
Date: Thu, 7 Oct 2021 17:32:18 +0100 [thread overview]
Message-ID: <YV8hEmSI3Yyociat@work-vm> (raw)
In-Reply-To: <20211007161716.453984-15-philmd@redhat.com>
* Philippe Mathieu-Daudé (philmd@redhat.com) wrote:
> SEV is a x86 specific feature, and the "sev_i386.h" header
> is already in target/i386/. Rename it as "sev.h" to simplify.
>
> Patch created mechanically using:
>
> $ git mv target/i386/sev_i386.h target/i386/sev.h
> $ sed -i s/sev_i386.h/sev.h/ $(git grep -l sev_i386.h)
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> target/i386/{sev_i386.h => sev.h} | 0
> hw/i386/x86.c | 2 +-
> target/i386/cpu.c | 2 +-
> target/i386/kvm/kvm.c | 2 +-
> target/i386/monitor.c | 2 +-
> target/i386/sev-stub.c | 2 +-
> target/i386/sev-sysemu-stub.c | 2 +-
> target/i386/sev.c | 2 +-
> 8 files changed, 7 insertions(+), 7 deletions(-)
> rename target/i386/{sev_i386.h => sev.h} (100%)
>
> diff --git a/target/i386/sev_i386.h b/target/i386/sev.h
> similarity index 100%
> rename from target/i386/sev_i386.h
> rename to target/i386/sev.h
> diff --git a/hw/i386/x86.c b/hw/i386/x86.c
> index 0c7c054e3a0..76de7e2265e 100644
> --- a/hw/i386/x86.c
> +++ b/hw/i386/x86.c
> @@ -47,7 +47,7 @@
> #include "hw/i386/fw_cfg.h"
> #include "hw/intc/i8259.h"
> #include "hw/rtc/mc146818rtc.h"
> -#include "target/i386/sev_i386.h"
> +#include "target/i386/sev.h"
>
> #include "hw/acpi/cpu_hotplug.h"
> #include "hw/irq.h"
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index b54b98551e9..8289dc87bd5 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -26,7 +26,7 @@
> #include "sysemu/reset.h"
> #include "sysemu/hvf.h"
> #include "kvm/kvm_i386.h"
> -#include "sev_i386.h"
> +#include "sev.h"
> #include "qapi/error.h"
> #include "qapi/qapi-visit-machine.h"
> #include "qapi/qmp/qerror.h"
> diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c
> index f25837f63f4..a5f6ff63c81 100644
> --- a/target/i386/kvm/kvm.c
> +++ b/target/i386/kvm/kvm.c
> @@ -28,7 +28,7 @@
> #include "sysemu/kvm_int.h"
> #include "sysemu/runstate.h"
> #include "kvm_i386.h"
> -#include "sev_i386.h"
> +#include "sev.h"
> #include "hyperv.h"
> #include "hyperv-proto.h"
>
> diff --git a/target/i386/monitor.c b/target/i386/monitor.c
> index ea836678f51..109e4e61c0a 100644
> --- a/target/i386/monitor.c
> +++ b/target/i386/monitor.c
> @@ -32,7 +32,7 @@
> #include "sysemu/kvm.h"
> #include "sysemu/sev.h"
> #include "qapi/error.h"
> -#include "sev_i386.h"
> +#include "sev.h"
> #include "qapi/qapi-commands-misc-target.h"
> #include "qapi/qapi-commands-misc.h"
> #include "hw/i386/pc.h"
> diff --git a/target/i386/sev-stub.c b/target/i386/sev-stub.c
> index 170e9f50fee..7e8b6f9a259 100644
> --- a/target/i386/sev-stub.c
> +++ b/target/i386/sev-stub.c
> @@ -13,7 +13,7 @@
>
> #include "qemu/osdep.h"
> #include "qapi/error.h"
> -#include "sev_i386.h"
> +#include "sev.h"
>
> bool sev_enabled(void)
> {
> diff --git a/target/i386/sev-sysemu-stub.c b/target/i386/sev-sysemu-stub.c
> index d556b4f091f..8082781febf 100644
> --- a/target/i386/sev-sysemu-stub.c
> +++ b/target/i386/sev-sysemu-stub.c
> @@ -14,7 +14,7 @@
> #include "qemu/osdep.h"
> #include "qapi/qapi-commands-misc-target.h"
> #include "qapi/error.h"
> -#include "sev_i386.h"
> +#include "sev.h"
>
> SevInfo *sev_get_info(void)
> {
> diff --git a/target/i386/sev.c b/target/i386/sev.c
> index 5cbbcf0bb93..e43bbf3a17d 100644
> --- a/target/i386/sev.c
> +++ b/target/i386/sev.c
> @@ -25,7 +25,7 @@
> #include "qemu/uuid.h"
> #include "crypto/hash.h"
> #include "sysemu/kvm.h"
> -#include "sev_i386.h"
> +#include "sev.h"
> #include "sysemu/sysemu.h"
> #include "sysemu/runstate.h"
> #include "trace.h"
> --
> 2.31.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2021-10-07 16:49 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 16:16 [PATCH v4 00/23] target/i386/sev: Housekeeping SEV + measured Linux SEV guest Philippe Mathieu-Daudé
2021-10-07 16:16 ` [PATCH v4 01/23] qapi/misc-target: Wrap long 'SEV Attestation Report' long lines Philippe Mathieu-Daudé
2021-10-07 16:16 ` [PATCH v4 02/23] qapi/misc-target: Group SEV QAPI definitions Philippe Mathieu-Daudé
2021-10-07 16:16 ` [PATCH v4 03/23] target/i386/kvm: Introduce i386_softmmu_kvm Meson source set Philippe Mathieu-Daudé
2021-10-07 16:16 ` [PATCH v4 04/23] target/i386/kvm: Restrict SEV stubs to x86 architecture Philippe Mathieu-Daudé
2021-10-07 16:16 ` [PATCH v4 05/23] target/i386/sev: Prefix QMP errors with 'SEV' Philippe Mathieu-Daudé
2021-10-07 16:23 ` Dr. David Alan Gilbert
2021-10-07 16:16 ` [PATCH v4 06/23] target/i386/monitor: Return QMP error when SEV is not enabled for guest Philippe Mathieu-Daudé
2021-10-07 16:17 ` [PATCH v4 07/23] target/i386/cpu: Add missing 'qapi/error.h' header Philippe Mathieu-Daudé
2021-10-07 16:17 ` [PATCH v4 08/23] target/i386/sev_i386.h: Remove unused headers Philippe Mathieu-Daudé
2021-10-07 16:17 ` [PATCH v4 09/23] target/i386/sev: Remove sev_get_me_mask() Philippe Mathieu-Daudé
2021-10-07 16:17 ` [PATCH v4 10/23] target/i386/sev: Mark unreachable code with g_assert_not_reached() Philippe Mathieu-Daudé
2021-10-07 16:17 ` [PATCH v4 11/23] target/i386/sev: sev_get_attestation_report use g_autofree Philippe Mathieu-Daudé
2021-10-07 16:17 ` [PATCH v4 12/23] target/i386/sev: Use g_autofree in sev_launch_get_measure() Philippe Mathieu-Daudé
2021-10-07 16:28 ` Dov Murik
2021-10-12 6:15 ` Dov Murik
2021-10-07 16:17 ` [PATCH v4 13/23] target/i386/sev: Restrict SEV to system emulation Philippe Mathieu-Daudé
2021-10-07 16:17 ` [PATCH v4 14/23] target/i386/sev: Rename sev_i386.h -> sev.h Philippe Mathieu-Daudé
2021-10-07 16:32 ` Dr. David Alan Gilbert [this message]
2021-10-07 16:17 ` [PATCH v4 15/23] target/i386/sev: Declare system-specific functions in 'sev.h' Philippe Mathieu-Daudé
2021-10-07 16:17 ` [PATCH v4 16/23] target/i386/sev: Remove stubs by using code elision Philippe Mathieu-Daudé
2021-10-07 17:07 ` Dr. David Alan Gilbert
2021-10-07 17:18 ` Philippe Mathieu-Daudé
2021-10-07 17:22 ` Dr. David Alan Gilbert
2021-10-08 11:46 ` Paolo Bonzini
2021-10-07 17:27 ` Daniel P. Berrangé
2021-10-07 19:51 ` Eric Blake
2021-10-07 16:17 ` [PATCH v4 17/23] target/i386/sev: Move qmp_query_sev_attestation_report() to sev.c Philippe Mathieu-Daudé
2021-10-07 16:17 ` [PATCH v4 18/23] target/i386/sev: Move qmp_sev_inject_launch_secret() " Philippe Mathieu-Daudé
2021-10-07 16:17 ` [PATCH v4 19/23] target/i386/sev: Move qmp_query_sev_capabilities() " Philippe Mathieu-Daudé
2021-10-07 16:17 ` [PATCH v4 20/23] target/i386/sev: Move qmp_query_sev_launch_measure() " Philippe Mathieu-Daudé
2021-10-07 16:17 ` [PATCH v4 21/23] target/i386/sev: Move qmp_query_sev() & hmp_info_sev() " Philippe Mathieu-Daudé
2021-10-07 16:17 ` [PATCH v4 22/23] monitor: Reduce hmp_info_sev() declaration Philippe Mathieu-Daudé
2021-10-07 16:17 ` [PATCH v4 23/23] MAINTAINERS: Cover SEV-related files with X86/KVM section Philippe Mathieu-Daudé
2021-10-07 16:22 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YV8hEmSI3Yyociat@work-vm \
--to=dgilbert@redhat.com \
--cc=brijesh.singh@amd.com \
--cc=dovmurik@linux.ibm.com \
--cc=ehabkost@redhat.com \
--cc=jejb@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=slp@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).