qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: Hanna Reitz <hreitz@redhat.com>,
	Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
	Daniel Berrange <berrange@redhat.com>,
	qemu-devel <qemu-devel@nongnu.org>,
	qemu-block@nongnu.org
Subject: Re: [PATCH v2 0/6] iotests: update environment and linting configuration
Date: Mon, 27 Sep 2021 11:31:16 +0200	[thread overview]
Message-ID: <YVGPZJpyhuHdbaMB@redhat.com> (raw)
In-Reply-To: <CAFn=p-au+c1m8RGn2T7ceYvsk8qDJ=HCkLAPbqFydzN1_F4eWg@mail.gmail.com>

Am 24.09.2021 um 20:13 hat John Snow geschrieben:
> On Thu, Sep 23, 2021 at 2:07 PM John Snow <jsnow@redhat.com> wrote:
> 
> > GitLab: https://gitlab.com/jsnow/qemu/-/commits/python-package-iotest-pt1
> > CI: https://gitlab.com/jsnow/qemu/-/pipelines/376236687
> >
> > This series partially supersedes:
> >   [PATCH v3 00/16] python/iotests: Run iotest linters during Python CI'
> >
> > Howdy, this is good stuff we want even if we aren't yet in agreement
> > about the best way to run iotest 297 from CI.
> >
> > - Update linting config to tolerate pylint 2.11.1
> > - Eliminate sys.path hacking in individual test files
> > - make mypy execution in test 297 faster
> >
> > The rest of the actual "run at CI time" stuff can get handled separately
> > and later pending some discussion on the other series.
> >
> > V2:
> >
> > 001/6:[0011] [FC] 'iotests: add 'qemu' package location to PYTHONPATH in
> > testenv'
> > 002/6:[0025] [FC] 'iotests: add warning for rogue 'qemu' packages'
> >
> > - Squashed in a small optimization from Vladimir to 001, kept R-Bs.
> > - Fixed the package detection logic to not panic if it can't find
> >   'qemu' at all (kwolf)
> > - Updated commit messages for the first two patches.

> Patch 2 can just be dropped, and everything else is reviewed, so I think
> this can be staged at your leisure.

Thanks, applied to the block branch (without patch 2).

Kevin



      reply	other threads:[~2021-09-27  9:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-23 18:07 [PATCH v2 0/6] iotests: update environment and linting configuration John Snow
2021-09-23 18:07 ` [PATCH v2 1/6] iotests: add 'qemu' package location to PYTHONPATH in testenv John Snow
2021-09-23 18:07 ` [PATCH v2 2/6] iotests: add warning for rogue 'qemu' packages John Snow
2021-09-23 18:32   ` Vladimir Sementsov-Ogievskiy
2021-09-23 18:44     ` John Snow
2021-09-23 20:27       ` Vladimir Sementsov-Ogievskiy
2021-09-24 18:11         ` John Snow
2021-09-23 18:07 ` [PATCH v2 3/6] iotests/linters: check mypy files all at once John Snow
2021-09-23 18:07 ` [PATCH v2 4/6] iotests/mirror-top-perms: Adjust imports John Snow
2021-09-23 18:07 ` [PATCH v2 5/6] iotests/migrate-bitmaps-test: delint John Snow
2021-09-23 18:07 ` [PATCH v2 6/6] iotests: Update for pylint 2.11.1 John Snow
2021-09-24 18:13 ` [PATCH v2 0/6] iotests: update environment and linting configuration John Snow
2021-09-27  9:31   ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YVGPZJpyhuHdbaMB@redhat.com \
    --to=kwolf@redhat.com \
    --cc=berrange@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).