qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: blockdev driver=file,filename=/dev/block forbidden?
Date: Wed, 29 Sep 2021 12:35:22 +0100	[thread overview]
Message-ID: <YVRPeq/1RI0/LPOG@redhat.com> (raw)
In-Reply-To: <ed1f265b-6db8-846e-cb52-09c3999d07bf@msgid.tls.msk.ru>

On Wed, Sep 29, 2021 at 02:21:58PM +0300, Michael Tokarev wrote:
> Commit 8d17adf34f501ded65a106572740760f0a75577c
> "block: remove support for using "file" driver with block/char devices"
> explicitly forbids usage of file driver for block devices.
> 
> But _why_?
> 
> Hasn't we always used file for everything on *nix? And what's the _actual_
> difference between file and host_device?

There are various things QEMU does differently for plain files vs
block devices. The check for read-only volume, determining data
transfer size, media geometry, supporting discard. This is seen
in the BlockDriver structs that have different callbacks for each.

> Please note this change has been added to qemu long before libvirt has
> been adapted (I guess there's no released libvirt can be used with
> qemu 6.0+).

Can you show your libvirt guest XML config that is causing trouble, as
it has done the right thing here for  a long while AFAIK, so I suspect
a mis-configuration.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2021-09-29 11:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-29 11:21 blockdev driver=file,filename=/dev/block forbidden? Michael Tokarev
2021-09-29 11:35 ` Daniel P. Berrangé [this message]
2021-09-29 11:46   ` Michael Tokarev
2021-09-29 12:06     ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YVRPeq/1RI0/LPOG@redhat.com \
    --to=berrange@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).