From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C299C433FE for ; Fri, 1 Oct 2021 08:22:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0AA7660FC2 for ; Fri, 1 Oct 2021 08:22:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0AA7660FC2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:51046 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mWDon-0002ZH-Rl for qemu-devel@archiver.kernel.org; Fri, 01 Oct 2021 04:22:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49538) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mWDnu-0001Xy-9m for qemu-devel@nongnu.org; Fri, 01 Oct 2021 04:22:02 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:37394) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mWDnq-0004ii-Th for qemu-devel@nongnu.org; Fri, 01 Oct 2021 04:22:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633076517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kVD86ZZFuJiu13hUXsVtW6OXDFiTvUu6H6hAMj/Gmng=; b=Z9OC6odWnGw/h81zRhIPlCsyyLwQpdr1ir5JwNkbAJm6s47gQHQQgUPnnRl/kVt+YsfeQD WsKTxlqbuS54RmAHcIYzDSVEwh8Z+UoOhVL6s2Io3tdFbImRS9cNL6xKttaopo9t5CmiiM XZ0sn/YLLcRex0eNMzMMtkAZmaBDdaA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-185-mzPN7A3ROFiG1t7Hx7WEpA-1; Fri, 01 Oct 2021 04:21:54 -0400 X-MC-Unique: mzPN7A3ROFiG1t7Hx7WEpA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 56FE6101F004; Fri, 1 Oct 2021 08:21:53 +0000 (UTC) Received: from redhat.com (unknown [10.39.194.159]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BAE395F4F8; Fri, 1 Oct 2021 08:21:38 +0000 (UTC) Date: Fri, 1 Oct 2021 10:21:36 +0200 From: Kevin Wolf To: John Snow Subject: Re: Running 297 from GitLab CI Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Hanna Reitz , qemu-devel , qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 30.09.2021 um 23:28 hat John Snow geschrieben: > Hiya, I was talking this over with Hanna in review to '[PATCH v3 00/16] > python/iotests: Run iotest linters during Python CI' [1] and I have some > doubt about what you'd personally like to see happen, here. > > In a nutshell, I split out 'linters.py' from 297 and keep all of the > iotest-bits in 297 and all of the generic "run the linters" bits in > linters.py, then I run linters.py from the GitLab python CI jobs. > > I did this so that iotest #297 would continue to work exactly as it had, > but trying to serve "two masters" in the form of two test suites means some > non-beautiful design decisions. Hanna suggested we just outright drop test > 297 to possibly improve the factoring of the tests. > > I don't want to do that unless you give it the go-ahead, though. I wanted > to hear your feelings on if we still want to keep 297 around or not. My basic requirement is that the checks are run somewhere in my local testing before I prepare a pull request. This means it could be done by iotests in any test that runs for -raw or -qcow2, or in 'make check'. So if you have a replacement somewhere in 'make check', dropping 297 is fine with me. If I have to run something entirely different, you may need to invest a bit more effort to convince me. ;-) Kevin