From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA4D9C433EF for ; Tue, 5 Oct 2021 17:53:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B5D561251 for ; Tue, 5 Oct 2021 17:53:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9B5D561251 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:40228 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mXocn-0004Mb-O0 for qemu-devel@archiver.kernel.org; Tue, 05 Oct 2021 13:53:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34900) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXoF2-0002Qd-Na for qemu-devel@nongnu.org; Tue, 05 Oct 2021 13:28:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:37026) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mXoEz-0007md-0R for qemu-devel@nongnu.org; Tue, 05 Oct 2021 13:28:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633454909; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0pah1vYa+J7Q7Qdh0WNOxLsy7Ed1M9MlqjiO8WeUsLw=; b=ivcBJIRjAN2U5m+eU/MiXhUqyNHbZfPQC7d/eO/wiLO5ofD5dhEaJEfUdUz851mb4PPpJu Y4Sg+d9bYq1F0NfGWTvBQpT8mdqK++RDSFGGQTtsdREYk891jwZvOvLyTUhmdKgP3woc+r IJsq+r4pUsKdJFRUSSdCE/3ONnaXuks= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-523-jsBUO3DHNQOTQ6aybYC9Nw-1; Tue, 05 Oct 2021 13:28:28 -0400 X-MC-Unique: jsBUO3DHNQOTQ6aybYC9Nw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5C0B8802C87; Tue, 5 Oct 2021 17:28:27 +0000 (UTC) Received: from horse.redhat.com (unknown [10.22.9.147]) by smtp.corp.redhat.com (Postfix) with ESMTP id 133335F4E7; Tue, 5 Oct 2021 17:28:22 +0000 (UTC) Received: by horse.redhat.com (Postfix, from userid 10451) id A28B6220BDB; Tue, 5 Oct 2021 13:28:21 -0400 (EDT) Date: Tue, 5 Oct 2021 13:28:21 -0400 From: Vivek Goyal To: Stefan Hajnoczi Subject: Re: [Virtio-fs] [PATCH 13/13] virtiofsd, seccomp: Add clock_nanosleep() to allow list Message-ID: References: <20210930153037.1194279-1-vgoyal@redhat.com> <20210930153037.1194279-14-vgoyal@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vgoyal@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=vgoyal@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.066, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: virtio-fs@redhat.com, qemu-devel@nongnu.org, miklos@szeredi.hu Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Oct 05, 2021 at 04:50:43PM +0100, Stefan Hajnoczi wrote: > On Tue, Oct 05, 2021 at 11:16:18AM -0400, Vivek Goyal wrote: > > On Tue, Oct 05, 2021 at 01:22:58PM +0100, Stefan Hajnoczi wrote: > > > On Thu, Sep 30, 2021 at 11:30:37AM -0400, Vivek Goyal wrote: > > > > g_usleep() calls nanosleep() and that now seems to call clock_nanosleep() > > > > syscall. Now these patches are making use of g_usleep(). So add > > > > clock_nanosleep() to list of allowed syscalls. > > > > > > > > Signed-off-by: Vivek Goyal > > > > --- > > > > tools/virtiofsd/passthrough_seccomp.c | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/tools/virtiofsd/passthrough_seccomp.c b/tools/virtiofsd/passthrough_seccomp.c > > > > index cd24b40b78..03080806c0 100644 > > > > --- a/tools/virtiofsd/passthrough_seccomp.c > > > > +++ b/tools/virtiofsd/passthrough_seccomp.c > > > > @@ -117,6 +117,7 @@ static const int syscall_allowlist[] = { > > > > SCMP_SYS(writev), > > > > SCMP_SYS(umask), > > > > SCMP_SYS(nanosleep), > > > > + SCMP_SYS(clock_nanosleep), > > > > > > This patch can be dropped once sleep has been replaced by a condvar. > > > > There is another sleep in do_pool_destroy() where we are waiting > > for all current threads to exit. > > > > do_pool_destroy() { > > g_usleep(10000); > > } > > That won't be necessary if there's a way to avoid the thread pool :). > See my other reply about closing the OFD instead of using signals to > cancel blocking fcntl(2). Hi Stefan, I responded to that email already. man fnctl does not say anything about closing fd will unblock the waiter with -EINTR and I had a quick look at kernel code and did not find anything which suggested closing fd will unblock current waiters. So is this something you know works or you want me to try and see if it works? Thanks Vivek