From: Kevin Wolf <kwolf@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH 0/2] failover: fix a regression introduced by JSON'ification of -device
Date: Tue, 19 Oct 2021 12:54:54 +0200 [thread overview]
Message-ID: <YW6j/sURMaQ/WIGs@redhat.com> (raw)
In-Reply-To: <20211019071532.682717-1-lvivier@redhat.com>
Am 19.10.2021 um 09:15 hat Laurent Vivier geschrieben:
> Kevin's series "qdev: Add JSON -device" has introduced a regression
> in failover by removing the QemuOpts parameter.
>
> This series fixes that (see PATCH 1) and also makes some cleanup
> in the hide_device function caller to remove the failover specific
> code from qdev_device_add_from_qdict() and clarify the fact that
> a primary device must have an id.
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
prev parent reply other threads:[~2021-10-19 10:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 7:15 [PATCH 0/2] failover: fix a regression introduced by JSON'ification of -device Laurent Vivier
2021-10-19 7:15 ` [PATCH 1/2] " Laurent Vivier
2021-10-19 7:15 ` [PATCH 2/2] qdev/qbus: remove failover specific code Laurent Vivier
2021-10-19 10:54 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YW6j/sURMaQ/WIGs@redhat.com \
--to=kwolf@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jasowang@redhat.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).